8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
Only change the testcase lib file, the risk is low.
This is similar to JDK-8309138, but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.
Additional testing:
docker-tests.log
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/539/head:pull/539
$ git checkout pull/539
Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/539/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 539
View PR using the GUI difftool:
$ git pr show -t 539
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/539.diff
Webrev
Link to Webrev Comment