Skip to content

8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 8, 2024

Hi all,
Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
Only change the testcase lib file, the risk is low.
This is similar to JDK-8309138, but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.

Additional testing:

  • hotspot/test/runtime/containers/docker

docker-tests.log


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335845 needs maintainer approval

Issue

  • JDK-8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir (Bug - P4 - Rejected)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/539/head:pull/539
$ git checkout pull/539

Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 539

View PR using the GUI difftool:
$ git pr show -t 539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/539.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2024
@sendaoYan
Copy link
Member Author

/approval request Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. Only change the testcase lib file, the risk is low. The changed has been verified.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@sendaoYan
8335845: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 8, 2024

The GHA report several failures.

  1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3
  1. Linux x86 gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java report crash CompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR.
  2. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

@sendaoYan
Copy link
Member Author

Thanks for the review.

@openjdk openjdk bot removed the approval label Aug 20, 2024
@sendaoYan
Copy link
Member Author

Include by #538

@sendaoYan sendaoYan closed this Aug 20, 2024
@sendaoYan sendaoYan deleted the jbs8335845 branch August 20, 2024 16:13
@sendaoYan sendaoYan restored the jbs8335845 branch January 31, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants