-
Notifications
You must be signed in to change notification settings - Fork 162
8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Testing in GHA: OK |
Mailing list message from Thorsten Glaser on jdk8u-dev: On Mon, 6 May 2024, Zdenek Zambersky wrote:
LTS is not available for all architectures, ELTS for even less. HTH & HAND, |
It is still strange that architectures were only removed from |
Mailing list message from Thorsten Glaser on jdk8u-dev: On Tue, 7 May 2024, Zdenek Zambersky wrote:
buster went EOL on 2022-09-10 and entered LTS back then. But with the bookworm release and the t64 transition in sid, Unfortunately, this was a bit uncoordinated and the announcement, bye, |
Thanks for detailed info. Removal of arches after running out of space is unfortunate. We could alternatively switch repo to |
|
Mailing list message from Thorsten Glaser on jdk8u-dev: On Thu, 9 May 2024, Zdenek Zambersky wrote:
You?re welcome.
bullseye will EOL and enter LTS around 2024-08-14, I expect that some time between this, it?ll be copied to LTS architectures are currently: i386, amd64, armhf, arm64 bye, |
/approval request Fixes cross-builds in GHA by updating Debian used for sysroot, affects GHA testing only |
/approve yes |
@jerboaa |
/integrate |
Going to push as commit 9da7380.
Your commit was automatically rebased without conflicts. |
Updates GHA to use Debian
bullseye
for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in repos ofbuster
(currently used Debian). Not sure why arches disappeared, but turns out thatbuster
soon reaches end of LTS support (2024-06-30).As Debian
bullseye
(next version) again has all aches in its repos, update solves both issues. In newer JDKs, sysroot update to bullseye was included in JDK-8293107 (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le) with errors such as:Seems to be JDK-8281096 (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/491/head:pull/491
$ git checkout pull/491
Update a local copy of the PR:
$ git checkout pull/491
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/491/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 491
View PR using the GUI difftool:
$ git pr show -t 491
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/491.diff
Webrev
Link to Webrev Comment