Skip to content

8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented May 6, 2024

Updates GHA to use Debian bullseye for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in repos of buster (currently used Debian). Not sure why arches disappeared, but turns out that buster soon reaches end of LTS support (2024-06-30).

As Debian bullseye (next version) again has all aches in its repos, update solves both issues. In newer JDKs, sysroot update to bullseye was included in JDK-8293107 (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le) with errors such as:

/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/adlc/arena.cpp:82:19: error: ISO C++17 does not allow ‘register’ storage class specifier [-Werror=register]
   82 |   register Chunk *k = _first;
      |                   ^

Seems to be JDK-8281096 (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331730 needs maintainer approval

Issue

  • JDK-8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/491/head:pull/491
$ git checkout pull/491

Update a local copy of the PR:
$ git checkout pull/491
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 491

View PR using the GUI difftool:
$ git pr show -t 491

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/491.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
  • 663ecc7: 8333126: Bump update version of OpenJDK: 8u432
  • db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • 012f59c: 8316138: Add GlobalSign 2 TLS root certificates
  • 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  • ab408de: 8235834: IBM-943 charset encoder needs updating
  • b3308b1: 8328825: Google CAInterop test failures
  • 216b8cb: 8331791: [8u] AIX build break from JDK-8320005 backport
  • 853a87a: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • 89def4d: 8331980: [8u] Problem list CAInterop.java#certignarootca test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@zzambers
Copy link
Contributor Author

zzambers commented May 6, 2024

Testing in GHA: OK
(This only affects cross-builds in Linux additional category, which all pass with this change. Test failures of other tests are unrelated.)

@zzambers zzambers changed the title [8u] GHA: update sysroot for cross builds to Debian bullseye 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye May 6, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2024
@mlbridge
Copy link

mlbridge bot commented May 6, 2024

Webrevs

@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Mailing list message from Thorsten Glaser on jdk8u-dev:

On Mon, 6 May 2024, Zdenek Zambersky wrote:

Not sure why arches disappeared, but
turns out that `buster` soon reaches end of LTS support

LTS is not available for all architectures, ELTS for even less.
(And backports are not even available for LTS.)

HTH & HAND,
//mirabilos
--
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

@zzambers
Copy link
Contributor Author

zzambers commented May 7, 2024

Mailing list message from Thorsten Glaser on jdk8u-dev:

On Mon, 6 May 2024, Zdenek Zambersky wrote:

Not sure why arches disappeared, but
turns out that buster soon reaches end of LTS support

LTS is not available for all architectures, ELTS for even less. (And backports are not even available for LTS.)

It is still strange that architectures were only removed from buster repo recently. (It has been in LTS for a long time)

@mlbridge
Copy link

mlbridge bot commented May 8, 2024

Mailing list message from Thorsten Glaser on jdk8u-dev:

On Tue, 7 May 2024, Zdenek Zambersky wrote:

On Mon, 6 May 2024, Zdenek Zambersky wrote:

Not sure why arches disappeared, but
turns out that `buster` soon reaches end of LTS support

LTS is not available for all architectures, ELTS for even less. (And
backports are not even available for LTS.)

It is still strange that architectures were only removed from `buster`
repo recently. (It has been in LTS for a long time)

buster went EOL on 2022-09-10 and entered LTS back then.
LTS uses the same debian-security repos as normal security
updates but is only available for a limited set of architectures;
the others have stayed present but frozen, no longer updated.

But with the bookworm release and the t64 transition in sid,
mirrors ran out of disc space, so the frozen parts of buster
(anything other than the debian-security part for LTS arches)
have been copied to archive.d.o, then the buster parts for
n?n-LTS arches have been removed from the main mirror tree,
and shortly after 2024-06-30 when LTS will end, the remnants
will be removed from the main tree.

Unfortunately, this was a bit uncoordinated and the announcement,
while present, was not as clear as it could have been and did not
come sufficiently ahead of time. The relevant teams got sufficient
responses from irritated users already, so I hope they?ll improve
the next time ;-)

bye,
//mirabilos
--
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

@zzambers
Copy link
Contributor Author

zzambers commented May 9, 2024

Mailing list message from Thorsten Glaser on jdk8u-dev:

On Tue, 7 May 2024, Zdenek Zambersky wrote:

On Mon, 6 May 2024, Zdenek Zambersky wrote:

Not sure why arches disappeared, but
turns out that buster soon reaches end of LTS support

LTS is not available for all architectures, ELTS for even less. (And
backports are not even available for LTS.)

It is still strange that architectures were only removed from buster
repo recently. (It has been in LTS for a long time)

buster went EOL on 2022-09-10 and entered LTS back then. LTS uses the same debian-security repos as normal security updates but is only available for a limited set of architectures; the others have stayed present but frozen, no longer updated.

But with the bookworm release and the t64 transition in sid, mirrors ran out of disc space, so the frozen parts of buster (anything other than the debian-security part for LTS arches) have been copied to archive.d.o, then the buster parts for n?n-LTS arches have been removed from the main mirror tree, and shortly after 2024-06-30 when LTS will end, the remnants will be removed from the main tree.

Unfortunately, this was a bit uncoordinated and the announcement, while present, was not as clear as it could have been and did not come sufficiently ahead of time. The relevant teams got sufficient responses from irritated users already, so I hope they?ll improve the next time ;-)

Thanks for detailed info. Removal of arches after running out of space is unfortunate. We could alternatively switch repo to archive.debian.org, but I like update to bullseye better. Hopefully history will not repeat itself with bullseye. :)

@openjdk
Copy link

openjdk bot commented May 9, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Mailing list message from Thorsten Glaser on jdk8u-dev:

On Thu, 9 May 2024, Zdenek Zambersky wrote:

Thanks for detailed info.

You?re welcome.

Hopefully history will not repeat itself with `bullseye`. :)

bullseye will EOL and enter LTS around 2024-08-14,
and its LTS will end around 2026-08-31.

I expect that some time between this, it?ll be copied to
archive.d.o, so from that time on, you could switch to
that except for the security updates.

LTS architectures are currently: i386, amd64, armhf, arm64

bye,
//mirabilos
--
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

@zzambers
Copy link
Contributor Author

/approval request Fixes cross-builds in GHA by updating Debian used for sysroot, affects GHA testing only

@openjdk
Copy link

openjdk bot commented May 13, 2024

@zzambers
8331730: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 13, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Jun 6, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@jerboaa
8331730: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 6, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Jun 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

Going to push as commit 9da7380.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
  • 663ecc7: 8333126: Bump update version of OpenJDK: 8u432
  • db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • 012f59c: 8316138: Add GlobalSign 2 TLS root certificates
  • 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  • ab408de: 8235834: IBM-943 charset encoder needs updating
  • b3308b1: 8328825: Google CAInterop test failures
  • 216b8cb: 8331791: [8u] AIX build break from JDK-8320005 backport
  • 853a87a: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • 89def4d: 8331980: [8u] Problem list CAInterop.java#certignarootca test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2024
@openjdk openjdk bot closed this Jun 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

@zzambers Pushed as commit 9da7380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants