8066708: JMXStartStopTest fails to connect to port 38112

[ktakakuri]

Hi all,

This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112.
I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable.

The risk is low as this fix only affects testing.
Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java

Thank you.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8066708 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8066708: JMXStartStopTest fails to connect to port 38112 (Bug - P1 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer) Review applies to 82318510
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/430/head:pull/430
$ git checkout pull/430

Update a local copy of the PR:
$ git checkout pull/430
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 430

View PR using the GUI difftool:
$ git pr show -t 430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/430.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into pr/429 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full (625e1e0c)
• 02: Full - Incremental (122fe0c8)
• 01: Full - Incremental (82318510)
• 00: Full (82318510)

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[phohensee]

windows-x86 GHA build failures appear unrelated.

[openjdk]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8066708: JMXStartStopTest fails to connect to port 38112

Reviewed-by: andrew, phh
Backport-of: d9fe0af0483e5954ba1d68107fb448669724a464

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 73056eb: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp
• b734886: 8315731: Open source several Swing Text related tests
• 068ed1f: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
• cb95a72: 8260380: Upgrade to LittleCMS 2.12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[ktakakuri]

/approval request I would like to backport this issue to 8u because the test fails also with jdk8.
There is no risk because it is a test-only fix. The test passes by backporting this issue after JDK-8035395. I tested it on Windows and Linux.

[openjdk]

@ktakakuri
8066708: The approval request has been created successfully.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk]

@ktakakuri This pull request is now open

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8066708
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[ktakakuri]

I resolved the conflicts.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[bridgekeeper]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request.
I comment to not close.

[openjdk]

@ktakakuri this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8066708
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[ktakakuri]

I resolved the conflict.
The conflict is due to an error in the backport #429 that led to an additional fix #541.

[gnu-andrew]

This one was difficult to review, because there are quite a few context differences from interim changes between 8035395 and 8066708. In the end, I applied the patch to 8u and compared the updated test with the 11u version rather than trying to compare the two patches.

This looks ok but it might be worth looking at bringing in some of the other fixes for this to get it closer to 11u. It certainly looks like the test has had a lot of churn.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8066708: The approval request has been approved.

[ktakakuri]

/integrate

[openjdk]

@ktakakuri
Your change (at version 625e1e0) is now ready to be sponsored by a Committer.

[gnu-andrew]

/approve yes

[gnu-andrew]

/sponsor

[openjdk]

@gnu-andrew
8066708: The approval request has been approved.

[openjdk]

Going to push as commit ec2bb45.
Since your change was applied there have been 4 commits pushed to the master branch:

• 73056eb: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp
• b734886: 8315731: Open source several Swing Text related tests
• 068ed1f: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java
• cb95a72: 8260380: Upgrade to LittleCMS 2.12

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @ktakakuri Pushed as commit ec2bb45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[zzambers]

There is a mistake in this backport causing JMXStartStopTest to fail. I have made another PR with fix.