Skip to content

Conversation

@HamzaBenyazid
Copy link

@HamzaBenyazid HamzaBenyazid commented Feb 8, 2026


Progress

  • JDK-8375742 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8375742: Test java/lang/invoke/MethodHandleProxies/Driver.java does not run Unnamed.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.org/jdk26u.git pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/42.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2026

👋 Welcome back HamzaBenyazid! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 8, 2026

@HamzaBenyazid This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8375742: Test java/lang/invoke/MethodHandleProxies/Driver.java does not run Unnamed.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d66fbe2: Merge
  • dc46cc6: 8376035: Remove EA from the JDK 26 version string with first RC promotion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport aaca0a2c1f3de06a1349ae9084e9e9dbec991421 8375742: Test java/lang/invoke/MethodHandleProxies/Driver.java does not run Unnamed.java Feb 8, 2026
@openjdk
Copy link

openjdk bot commented Feb 8, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 8, 2026
@openjdk
Copy link

openjdk bot commented Feb 8, 2026

⚠️ @HamzaBenyazid This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2026

Webrevs

@HamzaBenyazid
Copy link
Author

/approval JDK-8375742 request "Test java/lang/invoke/MethodHandleProxies/Driver.java does not run Unnamed.java"

@openjdk
Copy link

openjdk bot commented Feb 8, 2026

@HamzaBenyazid
JDK-8375742: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 8, 2026
@openjdk
Copy link

openjdk bot commented Feb 10, 2026

⚠️ @HamzaBenyazid the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8375742
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant