Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Feb 5, 2026

Fixes the +UCOH regression.

Additional testing:

  • GHA

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373021 needs maintainer approval

Issue

  • JDK-8373021: aarch64: MacroAssembler::arrays_equals reads out of bounds (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.org/jdk26u.git pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/40.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2026

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 5, 2026

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373021: aarch64: MacroAssembler::arrays_equals reads out of bounds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2c3ad0f425c75332412a5e8e5733dd0d073a09c8 8373021: aarch64: MacroAssembler::arrays_equals reads out of bounds Feb 5, 2026
@openjdk
Copy link

openjdk bot commented Feb 5, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 5, 2026
@shipilev shipilev marked this pull request as ready for review February 9, 2026 09:06
@openjdk
Copy link

openjdk bot commented Feb 9, 2026

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 9, 2026
@shipilev
Copy link
Member Author

shipilev commented Feb 9, 2026

/approval request Fixes the AArch64 bug with +UCOH. The patch is relatively new, only a few weeks old, but it is simple and has no bugtail. We have seen this crash in the wild, so there is user exposure. Applies cleanly. Basic tests pass.

@openjdk
Copy link

openjdk bot commented Feb 9, 2026

@shipilev
8373021: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 9, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2026

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant