8354894: java/lang/Thread/virtual/Starvation.java timeout on server with high CPUs

[rm-gh-8]

Backporting JDK-8354894: java/lang/Thread/virtual/Starvation.java timeout on server with high CPUs

For parity with Oracle JDK. Fix adjusts iteration count by dividing by CPU core count, and removed timeout=800 as default 120 timeout is now sufficient.

Merge conflict (resolved) was the change in the timeout.

Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64. Also ran a test on an EC2 instance (linux-x64) with high cpu count (r5dn.24xlarge - 96 core) and it finished under 1s:

(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/lang/Thread/virtual/Starvation.java

Results are attached.

linux-x64-96-core-test.log

linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8354894 needs maintainer approval

Issue

• JDK-8354894: java/lang/Thread/virtual/Starvation.java timeout on server with high CPUs (Bug - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/49.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354894: java/lang/Thread/virtual/Starvation.java timeout on server with high CPUs

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• 6cf94cc: 8317838: java/nio/channels/Channels/SocketChannelStreams.java running into timeout (aix)
• 25e491b: 8371759: Add missing @OverRide annotations in com.sun.imageio package
• 410cf86: 8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used
• ... and 45 more: https://git.openjdk.org/jdk25u-dev/compare/796f2b42b07c150602acc98fe1a9ad69c5bc5d0d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[shipilev]

AFAICS, the timeout=800 -> timeout=200 change was part of JDK-8260555: Change the default TIMEOUT_FACTOR from 4 to 1, which was reverted by JDK-8369491, but mainline just never needed to update the test back, because this fix landed.

[rm-gh-8]

AFAICS, the timeout=800 -> timeout=200 change was part of JDK-8260555: Change the default TIMEOUT_FACTOR from 4 to 1, which was reverted by JDK-8369491, but mainline just never needed to update the test back, because this fix landed.

The original commit indicates that the default 120 timeout is sufficient, so the explicit timeout can be removed. This was also tested in a 96 core EC2 instance.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (84e75d12)

[rm-gh-8]

/approval request for backport of JDK-8354894: java/lang/Thread/virtual/Starvation.java timeout on server with high CPUs.

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8354894: The approval request has been created successfully.

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 84e75d1) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit b7b842e.
Since your change was applied there have been 49 commits pushed to the master branch:

• 395b4c4: 8368754: runtime/cds/appcds/SignedJar.java log regex is too strict
• 6cf94cc: 8317838: java/nio/channels/Channels/SocketChannelStreams.java running into timeout (aix)
• 25e491b: 8371759: Add missing @OverRide annotations in com.sun.imageio package
• ... and 46 more: https://git.openjdk.org/jdk25u-dev/compare/796f2b42b07c150602acc98fe1a9ad69c5bc5d0d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit b7b842e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.