8378623: Use unique font names in FormatCharAdvanceTest#356
Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Open
8378623: Use unique font names in FormatCharAdvanceTest#356rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
bot
added
backport
|
|
Contributor
Author
|
/approval request for backport of JDK-8378623: Use unique font names in FormatCharAdvanceTest. This is a test fix. For parity with Oracle JDK. |
openjdk
bot
added
the
approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8378623: Use unique font names in FormatCharAdvanceTest.
This PR gives the TTF and Type1 test fonts unique names ("TTFTest" and "Type1Test") to work around a FontMetrics caching bug (JDK-8378622) where shared font names caused stale Type1 metrics to be used for TTF rendering, a problem exposed by the FreeType update in JDK-8373290.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/awt/font/TextLayout/FormatCharAdvanceTest.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/356/head:pull/356$ git checkout pull/356Update a local copy of the PR:
$ git checkout pull/356$ git pull https://git.openjdk.org/jdk25u-dev.git pull/356/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 356View PR using the GUI difftool:
$ git pr show -t 356Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/356.diff
Using Webrev
Link to Webrev Comment