Skip to content

8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java#347

Open
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8364927-V25
Open

8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java#347
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8364927-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Mar 4, 2026

Backporting JDK-8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java.

This PR fixes Fixes TestReclaimStringsLeaksMemory to properly guard against unsupported GC configurations by splitting from a single test with vm.gc == "null" requirement into 5 separate GC-specific tests (Serial, Parallel, G1, Shenandoah, Z), each with explicit @requires clauses that ensure the test only runs when the specified GC is supported, preventing test failures on VMs lacking particular GC implementations.

This PR is not clean because it does not include JDK-8260555 (openjdk/jdk@55e7af0), which added timeouts to numerous tests and would introduce a large commit dependency graph. Instead, the timeout has been directly incorporated into this specific test to reflect its expected execution time.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8364927 needs maintainer approval

Issue

  • JDK-8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/347/head:pull/347
$ git checkout pull/347

Update a local copy of the PR:
$ git checkout pull/347
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 347

View PR using the GUI difftool:
$ git pr show -t 347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/347.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2bfada3f58df6c041d948267368cbc4db915cac3 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java Mar 4, 2026
@openjdk
Copy link

openjdk bot commented Mar 4, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Mar 4, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review March 4, 2026 18:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2026

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 5, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Mar 6, 2026

/approval request for backport of JDK-8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java.

This is a test fix.

This PR is not clean because it does not include JDK-8260555 (openjdk/jdk@55e7af0), which added timeouts to numerous tests and would introduce a large commit dependency graph. Instead, the timeout has been directly incorporated into this specific test to reflect its expected execution time.

For parity with Oracle JDK.

@openjdk
Copy link

openjdk bot commented Mar 6, 2026

@rm-gh-8
8364927: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants