8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java#347
8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java#347rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java. This is a test fix. This PR is not clean because it does not include JDK-8260555 (openjdk/jdk@55e7af0), which added timeouts to numerous tests and would introduce a large commit dependency graph. Instead, the timeout has been directly incorporated into this specific test to reflect its expected execution time. For parity with Oracle JDK. |
Backporting JDK-8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java.
This PR fixes Fixes TestReclaimStringsLeaksMemory to properly guard against unsupported GC configurations by splitting from a single test with vm.gc == "null" requirement into 5 separate GC-specific tests (Serial, Parallel, G1, Shenandoah, Z), each with explicit @requires clauses that ensure the test only runs when the specified GC is supported, preventing test failures on VMs lacking particular GC implementations.
This PR is not clean because it does not include JDK-8260555 (openjdk/jdk@55e7af0), which added timeouts to numerous tests and would introduce a large commit dependency graph. Instead, the timeout has been directly incorporated into this specific test to reflect its expected execution time.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/347/head:pull/347$ git checkout pull/347Update a local copy of the PR:
$ git checkout pull/347$ git pull https://git.openjdk.org/jdk25u-dev.git pull/347/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 347View PR using the GUI difftool:
$ git pr show -t 347Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/347.diff
Using Webrev
Link to Webrev Comment