8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out#346
8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out#346rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8368001: java/text/Format/NumberFormat/NumberRoundTrip.java timed out.
This PR refactors NumberFormat round-trip test to address timeout issues (JDK-8260555) by reducing test scope from ~1000 locales × 4 factories × ~30 inputs to ~25% using JUnit 5 parameterized testing, improving average execution time while maintaining representative coverage through random locale sampling and preserving all critical edge case testing.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/text/Format/NumberFormat/NumberRoundTrip.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/346/head:pull/346$ git checkout pull/346Update a local copy of the PR:
$ git checkout pull/346$ git pull https://git.openjdk.org/jdk25u-dev.git pull/346/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 346View PR using the GUI difftool:
$ git pr show -t 346Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/346.diff
Using Webrev
Link to Webrev Comment