You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Backporting JDK-8068293: [TEST_BUG] Test closed/com/sun/java/swing/plaf/motif/InternalFrame/4150591/bug4150591.java fails with GTKLookAndFeel.
This PR fixes test bug4150591 by explicitly setting the Motif Look & Feel before instantiating MotifInternalFrameTitlePane, preventing NPE that occurred when running under GTK Look & Feel where activeCaptionBorder and inactiveCaptionBorder colors are undefined and caused BorderFactory.createBevelBorder() to fail .
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/swing/plaf/motif/bug4150591.java
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
openjdkbot
changed the title
Backport 26eed3b61e4987a2998f941d7d26790493850612
8068293: [TEST_BUG] Test closed/com/sun/java/swing/plaf/motif/InternalFrame/4150591/bug4150591.java fails with GTKLookAndFeel
Mar 3, 2026
This backport pull request has now been updated with issue from the original commit.
openjdkbot
added
backport
Port of a pull request already in a different code base
clean
Identical backport; no merge resolution required
labels
Mar 3, 2026
⚠️@rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request for backport of JDK-8068293: [TEST_BUG] Test closed/com/sun/java/swing/plaf/motif/InternalFrame/4150591/bug4150591.java fails with GTKLookAndFeel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvalRequires approval; will be removed when approval is receivedbackportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredrfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8068293: [TEST_BUG] Test closed/com/sun/java/swing/plaf/motif/InternalFrame/4150591/bug4150591.java fails with GTKLookAndFeel.
This PR fixes test bug4150591 by explicitly setting the Motif Look & Feel before instantiating MotifInternalFrameTitlePane, preventing NPE that occurred when running under GTK Look & Feel where activeCaptionBorder and inactiveCaptionBorder colors are undefined and caused BorderFactory.createBevelBorder() to fail .
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/swing/plaf/motif/bug4150591.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/341/head:pull/341$ git checkout pull/341Update a local copy of the PR:
$ git checkout pull/341$ git pull https://git.openjdk.org/jdk25u-dev.git pull/341/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 341View PR using the GUI difftool:
$ git pr show -t 341Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/341.diff
Using Webrev
Link to Webrev Comment