8355339: Test java/io/File/GetCanonicalPath.java failed: The specified network name is no longer available#340
8355339: Test java/io/File/GetCanonicalPath.java failed: The specified network name is no longer available#340rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8355339: Test java/io/File/GetCanonicalPath.java failed: The specified network name is no longer available. This PR adds ERROR_NETNAME_DELETED to the list of non-reportable Windows errors during path canonicalization to handle network share disconnection gracefully, preventing exceptions when canonicalizing paths to deleted/disconnected network resources, along with minor code formatting cleanup. For parity with Oracle JDK. Low Risk - this change makes the canonicalization more robust by treating network share deletion errors the |
Backporting JDK-8355339: Test java/io/File/GetCanonicalPath.java failed: The specified network name is no longer available.
This PR adds ERROR_NETNAME_DELETED to the list of non-reportable Windows errors during path canonicalization to handle network share disconnection gracefully, preventing exceptions when canonicalizing paths to deleted/disconnected network resources, along with minor code formatting cleanup.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/io/File/GetCanonicalPath.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/340/head:pull/340$ git checkout pull/340Update a local copy of the PR:
$ git checkout pull/340$ git pull https://git.openjdk.org/jdk25u-dev.git pull/340/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 340View PR using the GUI difftool:
$ git pr show -t 340Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/340.diff
Using Webrev
Link to Webrev Comment