8373690: Unexpected Keystore message using jdk.crypto.disabledAlgorithms#336
8373690: Unexpected Keystore message using jdk.crypto.disabledAlgorithms#336rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8373690: Unexpected Keystore message using jdk.crypto.disabledAlgorithms. This PR improves error messaging in KeyStore.getInstance(File, ...) methods to distinguish between "unrecognized keystore format" and "keystore format disabled by security policy" when auto-detecting keystore types from files. For parity with Oracle JDK. Low Risk - it only changes error message generation logic in the file-based keystore detection path, providing more specific exception messages when a keystore type is detected but disabled by jdk.crypto.disabledAlgorithms property, without altering any core keystore functionality or security behavior. |
Backporting JDK-8373690: Unexpected Keystore message using jdk.crypto.disabledAlgorithms.
This PR improves error messaging in KeyStore.getInstance(File, ...) methods to distinguish between "unrecognized keystore format" and "keystore format disabled by security policy" when auto-detecting keystore types from files.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/java/security/KeyStore/DisabledKnownType.java
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/336/head:pull/336$ git checkout pull/336Update a local copy of the PR:
$ git checkout pull/336$ git pull https://git.openjdk.org/jdk25u-dev.git pull/336/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 336View PR using the GUI difftool:
$ git pr show -t 336Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/336.diff
Using Webrev
Link to Webrev Comment