Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Feb 9, 2026

Backporting JDK-8367772: Refactor createUI in PassFailJFrame.

This PR refactors PassFailJFrame UI creation to use Builder pattern internally, eliminating parameter proliferation and code duplication.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/java/awt/regtesthelpers/PassFailJFrame.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367772 needs maintainer approval

Issue

  • JDK-8367772: Refactor createUI in PassFailJFrame (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/250/head:pull/250
$ git checkout pull/250

Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 250

View PR using the GUI difftool:
$ git pr show -t 250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/250.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 9, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d278043ddba0cd9ec3ddf8b490366965f5831a22 8367772: Refactor createUI in PassFailJFrame Feb 9, 2026
@openjdk
Copy link

openjdk bot commented Feb 9, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required

Development

Successfully merging this pull request may close these issues.

1 participant