Skip to content

Conversation

@vish-chan
Copy link
Contributor

@vish-chan vish-chan commented Feb 4, 2026

Clean backport of 8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF

This backport fixes a debug assert failure discovered by CTW. The fix adds CmpLTMask, RoundF, and RoundD nodes to the SuperWord truncation switch statement and includes reduced test cases.

Additional Testing:

  • New regression test fails without the fix, passes with it.
  • Linux x86_64 server fastebug compiler tests.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362979 needs maintainer approval

Issue

  • JDK-8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/232/head:pull/232
$ git checkout pull/232

Update a local copy of the PR:
$ git checkout pull/232
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 232

View PR using the GUI difftool:
$ git pr show -t 232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/232.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2026

👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@vish-chan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ea0b49c36db7dce508aec7e72e73c7274d65bc15 8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF Feb 4, 2026
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 4, 2026
@vish-chan vish-chan marked this pull request as ready for review February 4, 2026 23:17
@openjdk
Copy link

openjdk bot commented Feb 4, 2026

⚠️ @vish-chan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 4, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2026

Webrevs

@vish-chan
Copy link
Contributor Author

/approval request for Clean backport of 8362979 : C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF

This is a low risk fix adding 3 missing node types to Superword non-truncation list. Fixes debug assert failure with no impact in product.

@openjdk
Copy link

openjdk bot commented Feb 5, 2026

@vish-chan
8362979: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 5, 2026
@vish-chan
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 11, 2026
@openjdk
Copy link

openjdk bot commented Feb 11, 2026

@vish-chan
Your change (at version ba46679) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

1 participant