-
Notifications
You must be signed in to change notification settings - Fork 38
8372120: Add missing sound keyword to MIDI tests #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8372120: Add missing sound keyword to MIDI tests. This is a test fix. For parity with Oracle JDK. |
|
/integrate |
|
/sponsor |
|
Going to push as commit 5a27cfe.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit 5a27cfe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8372120: Add missing sound keyword to MIDI tests.
This PR adds the sound keyword to affected tests to ensure they run properly when audio hardware is available.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/sound/midi
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/220/head:pull/220$ git checkout pull/220Update a local copy of the PR:
$ git checkout pull/220$ git pull https://git.openjdk.org/jdk25u-dev.git pull/220/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 220View PR using the GUI difftool:
$ git pr show -t 220Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/220.diff
Using Webrev
Link to Webrev Comment