Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Jun 12, 2024

Hi, The same issue also exists in the JDK22U: I can reproduce this test[1] locally and use this clean patch can fix that issue, So I would like to backport this to JDK22U. This is a risc-v specific change. Backport is clean, risk is low.

Testing

  • test/jdk/jdk/incubator/vector on Banana Pi BPI-F3 board (with RVV1.0)

[1] https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/vectorapi/VectorGatherMaskFoldingTest.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333652 needs maintainer approval

Issue

  • JDK-8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/248/head:pull/248
$ git checkout pull/248

Update a local copy of the PR:
$ git checkout pull/248
$ git pull https://git.openjdk.org/jdk22u.git pull/248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 248

View PR using the GUI difftool:
$ git pr show -t 248

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/248.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ce5727df4436425b24b89f24c6e6b708575ec7c6 8333652: RISC-V: compiler/vectorapi/VectorGatherMaskFoldingTest.java fails when using RVV Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@openjdk openjdk bot added the approval label Jun 12, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

@zifeihan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant