Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8321204: C2: assert(false) failed: node should be in igvn hash table #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 6, 2024

Clean backport of JDK-8321204.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321204 needs maintainer approval

Issue

  • JDK-8321204: C2: assert(false) failed: node should be in igvn hash table (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/245/head:pull/245
$ git checkout pull/245

Update a local copy of the PR:
$ git checkout pull/245
$ git pull https://git.openjdk.org/jdk22u.git pull/245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 245

View PR using the GUI difftool:
$ git pr show -t 245

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/245.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d1aad71209092013a89b3b85a258dd4d2e31224a 8321204: C2: assert(false) failed: node should be in igvn hash table Jun 6, 2024
@openjdk
Copy link

openjdk bot commented Jun 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 6, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request The assertion has been hit several times in JDK 22. This backport fixes the assertion. It is very small, applies cleanly and tier 1-4 has passed. It only has an effect on debug builds.

@openjdk
Copy link

openjdk bot commented Jun 7, 2024

@TheRealMDoerr
8321204: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 7, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

@TheRealMDoerr This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant