Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8331931: JFR: Avoid loading regex classes during startup #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pengxiaolong
Copy link
Contributor

@pengxiaolong pengxiaolong commented Jun 4, 2024

Backport JDK-8331931 JFR: Avoid loading regex classes during startup

Validation

Run test make test TEST=jdk/jdk/jfr, all tests passed.

Test results: passed: 592
Report written to /local/home/xlpeng/repos/jdk22u-xlpeng/build/linux-aarch64-server-fastdebug/test-results/jtreg_test_jdk_jdk_jfr/html/report.html
Results written to /local/home/xlpeng/repos/jdk22u-xlpeng/build/linux-aarch64-server-fastdebug/test-support/jtreg_test_jdk_jdk_jfr
Finished running test 'jtreg:test/jdk/jdk/jfr'
Test report is stored in build/linux-aarch64-server-fastdebug/test-results/jtreg_test_jdk_jdk_jfr

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/jdk/jfr                              592   592     0     0   
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'linux-aarch64-server-fastdebug'


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331931 needs maintainer approval

Issue

  • JDK-8331931: JFR: Avoid loading regex classes during startup (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/241/head:pull/241
$ git checkout pull/241

Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.org/jdk22u.git pull/241/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 241

View PR using the GUI difftool:
$ git pr show -t 241

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/241.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2024

👋 Welcome back pengxiaolong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 242446b07fcfcac136510495d1ff16d26859aea4 8331931: JFR: Avoid loading regex classes during startup Jun 4, 2024
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

This backport pull request has now been updated with issue from the original commit.

@pengxiaolong pengxiaolong marked this pull request as ready for review June 4, 2024 23:28
@openjdk
Copy link

openjdk bot commented Jun 4, 2024

⚠️ @pengxiaolong This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2024

Webrevs

@pengxiaolong
Copy link
Contributor Author

/approval request Backport JDK-8331931 JFR: Avoid loading regex classes during startup to jdk22, I have validated the backport by running test jdk/jdk/jfr. Applies cleanly. Overall risk should be low, it's fairly simple change and related tests have passed.

@openjdk
Copy link

openjdk bot commented Jun 5, 2024

@pengxiaolong
8331931: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 5, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

@pengxiaolong This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant