8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

[sendaoYan]

Hi all,

This pull request contains a backport of commit f132b347 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 13 Aug 2024 and was reviewed by Rajan Halade.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8336854 needs maintainer approval

Issue

• JDK-8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/943/head:pull/943
$ git checkout pull/943

Update a local copy of the PR:
$ git checkout pull/943
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/943/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 943

View PR using the GUI difftool:
$ git pr show -t 943

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/943.diff

Webrev

Link to Webrev Comment

[sendaoYan]

/approval request Clean backport, to fix the test bug, trivial fix, no risk.

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• eb80936: 8316895: SeenThread::print_action_queue called on a null pointer
• b0da5c7: 8338110: Exclude Fingerprinter::do_type from ubsan checks
• 669c2b4: 8339080: Bump update version for OpenJDK: jdk-21.0.6
• 33f4d80: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture
• db914b7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
• 345b417: 8338286: GHA: Demote x86_32 to hotspot build only
• ec5976d: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
• 15664b1: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp
• dccf4de: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment
• f2c5ecf: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743
• ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/d5b8ea8dacdfb7cbd9e9d5fb98a2571db2e1bf6b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@sendaoYan
8336854: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (8981228d)

[GoeLin]

Hi, all three PRs for this change have failed. tests. Why?

[sendaoYan]

Hi, all three PRs for this change have failed. tests. Why?

Do you mean the CA tests run failed.
The test security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java fails often for very different reasons., that's why the prefixed PR of CA tests JDK-8334441 has marked CA tests as manually,

• Sporadic networking issues.
• Issues on CA side - including shaky infrastructure.
• No longer valid certificates.

[GoeLin]

I want to know why the GHA action tests failed.
Actually, I want to make sure you have checked the results of these... There is a failure on macos-aarch64 here.
It is not uncommon that I am asked to approve changes that cause failures in the GHA actions. Therefore I insist that the Fix request comment explains why the GHA actions failed if they do so.

[sendaoYan]

Sorry for the misunderstand.
The GHA report macos-aarch64 langtools/tier1 failed. Unfortunately the GHA doesn't show any messages for this failed, it seems like a environmental issue. This PR change the tests in test/jdk directory, this PR will not change the behavior of langtools/tier1 in theory, so I think the failed unreleated to this PR.

I try to rerun the failed job, the job report Artifact not found for name: bundles-macos-aarch64 at Get bundles stage, I will try to rerun all the jobs again.

[sendaoYan]

All the GHA tests passed after I rerun it.

[sendaoYan]

Hi, all three PRs for this change have failed. tests. Why?

1. GHA job of jdk21u-dev passed after I rerun it.
2. GHA job of jdk17u-dev failed seems to be GHA environmental issue.
3. GHA job of jdk11u-dev failed cause by known bug which is fixing by 8299635: Hotspot update for deprecated sprintf in Xcode 14 jdk11u-dev#2844

[sendaoYan]

Thanks for the approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version 8981228) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit e939761.
Since your change was applied there have been 17 commits pushed to the master branch:

• eb80936: 8316895: SeenThread::print_action_queue called on a null pointer
• b0da5c7: 8338110: Exclude Fingerprinter::do_type from ubsan checks
• 669c2b4: 8339080: Bump update version for OpenJDK: jdk-21.0.6
• 33f4d80: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture
• db914b7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
• 345b417: 8338286: GHA: Demote x86_32 to hotspot build only
• ec5976d: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
• 15664b1: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp
• dccf4de: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment
• f2c5ecf: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743
• ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/d5b8ea8dacdfb7cbd9e9d5fb98a2571db2e1bf6b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @sendaoYan Pushed as commit e939761.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.