Skip to content

8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 23, 2025

Hi all,

This pull request contains a backport of commit 03105fc9 from the openjdk/jdk repository.

The commit being backported was authored by Volkan Yazici on 25 Mar 2025 and was reviewed by Michael McMahon.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8351601 needs maintainer approval

Issue

  • JDK-8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1915/head:pull/1915
$ git checkout pull/1915

Update a local copy of the PR:
$ git checkout pull/1915
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1915

View PR using the GUI difftool:
$ git pr show -t 1915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1915.diff

Using Webrev

Link to Webrev Comment

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the JMH test bug, change has been verified locally, test-fix only, no risk.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 03105fc92505e9e367354e763b99cbe02bf473d6 8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@sendaoYan
8351601: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 24, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2025

Going to push as commit bc224e2.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2025
@openjdk openjdk bot closed this Jun 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2025
@openjdk
Copy link

openjdk bot commented Jun 30, 2025

@sendaoYan Pushed as commit bc224e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant