Skip to content

8355249: Remove the use of WMIC from the entire source code #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented Jun 23, 2025

Hi all,

This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code

JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.

Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java.

I confirmed that Win8301247Test.java passes on Windows Server 2022.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355249 needs maintainer approval

Issue

  • JDK-8355249: Remove the use of WMIC from the entire source code (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1912/head:pull/1912
$ git checkout pull/1912

Update a local copy of the PR:
$ git checkout pull/1912
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1912

View PR using the GUI difftool:
$ git pr show -t 1912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1912.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2025

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4458719a108f45d3744d47a6ea081fe9ec3e675e 8355249: Remove the use of WMIC from the entire source code Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant