8355249: Remove the use of WMIC from the entire source code #1912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code
JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.
Original patch does not apply cleanly because JDK-8340311 is not backported to jdk21. For this reason, I modified Win8301247Test.java instead of WindowsHelper.java.
I confirmed that Win8301247Test.java passes on Windows Server 2022.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1912/head:pull/1912
$ git checkout pull/1912
Update a local copy of the PR:
$ git checkout pull/1912
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1912/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1912
View PR using the GUI difftool:
$ git pr show -t 1912
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1912.diff
Using Webrev
Link to Webrev Comment