8313905: Checked_cast assert in CDS compare_by_loader

[GoeLin]

I backport this for parity with 21.0.7-oracle.

Resolved because "8313564: Fix -Wconversion warnings in classfile code" is not in 21.
Probably clean anyways.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8313905 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313905: Checked_cast assert in CDS compare_by_loader (Bug - P3 - Requested)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1290/head:pull/1290
$ git checkout pull/1290

Update a local copy of the PR:
$ git checkout pull/1290
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1290

View PR using the GUI difftool:
$ git pr show -t 1290

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1290.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (98fd3581)

[GoeLin]

GHA failure: twice wget issue, unrelated.

[TheRealMDoerr]

LGTM. Only the removed code differs because of different casts.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.