Skip to content

8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Jun 20, 2025

Backporting JDK-8344253: Test java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed. Fixes an intermittent failure with the java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java failed test in situations where a decrement wouldn't complete, since unsigned shift right twice would lead to decrementing estimated size by 0. Backporting alongside the related issue: JDK-8344253: openjdk/jdk21u-dev#1895. Ran GHA Sanity Checks, and local Tier 1 and 2. Patch is clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343426 needs maintainer approval

Issue

  • JDK-8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3668/head:pull/3668
$ git checkout pull/3668

Update a local copy of the PR:
$ git checkout pull/3668
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3668

View PR using the GUI difftool:
$ git pr show -t 3668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3668.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2b57f402c46104d4aba784a891ba90604f5e9e4c 8343426: ConcurrentSkipListMap.spliterator() can no longer split the stream Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport approval rfr Pull request is ready for review labels Jun 20, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant