Skip to content

8298907: nsk JDI tests pass if the debuggee failed to launch #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 17, 2025

I backport this to fix the test issues and keep the test suite up to date.

test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/popFrames/popframes001.java
Resolved Copyright as "8284161: Implementation of Virtual Threads (Preview)" is not in 17
but probably clean anyways.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8298907 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8298907: nsk JDI tests pass if the debuggee failed to launch

Issue

  • JDK-8298907: nsk JDI tests pass if the debuggee failed to launch (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3655/head:pull/3655
$ git checkout pull/3655

Update a local copy of the PR:
$ git checkout pull/3655
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3655

View PR using the GUI difftool:
$ git pr show -t 3655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3655.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a91143cc93fe3810ecca4b04c9f81c1b967db0ed 8298907: nsk JDI tests pass if the debuggee failed to launch Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2025

Webrevs

@openjdk openjdk bot added the approval label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant