Skip to content

8288746: HttpClient resources could be reclaimed more eagerly #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 17, 2025

I backport this for parity with 17.0.17-oracle.

Some trivial resolves were needed.

Resolved module-info.java due to context.

Resolved test/jdk/java/net/httpclient/AsFileDownloadTest.java
as several later changes have been backported already.

Resolved Copyright in test/jdk/java/net/httpclient/DigestEchoClient.java.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8288746 needs maintainer approval

Issue

  • JDK-8288746: HttpClient resources could be reclaimed more eagerly (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3654/head:pull/3654
$ git checkout pull/3654

Update a local copy of the PR:
$ git checkout pull/3654
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3654

View PR using the GUI difftool:
$ git pr show -t 3654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3654.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f3f078846feae66d3504d50081353f74bd4891d7 8288746: HttpClient resources could be reclaimed more eagerly Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant