Skip to content

8346871: Improve robustness of java/util/zip/EntryCount64k.java test #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pr/3649
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 16, 2025

I backport this for parity with 17.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346871 needs maintainer approval

Integration blocker

 ⚠️ Dependency #3649 must be integrated first

Issue

  • JDK-8346871: Improve robustness of java/util/zip/EntryCount64k.java test (Sub-task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3651/head:pull/3651
$ git checkout pull/3651

Update a local copy of the PR:
$ git checkout pull/3651
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3651/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3651

View PR using the GUI difftool:
$ git pr show -t 3651

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3651.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/3649 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 24c5ff7ba58cb7cf93df07f81484cd8fae60e31e 8346871: Improve robustness of java/util/zip/EntryCount64k.java test Jun 16, 2025
@openjdk
Copy link

openjdk bot commented Jun 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2025

Webrevs

@openjdk openjdk bot added the approval label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant