8312475: org.jline.util.PumpReader signed byte problem

[Baraa-Hasheesh]

Clean Backport JDK-8312475: SonarCloud reports a possible issue in read method

• buffer.get() reads a signed byte so it has a range of -128-127
• When end of file is reached the read method returns -1 signed integer

When the buffer.get() reads -1 => it returns 0xFF as a signed byte value, this causes the SonarCloud to confuse the possibility that the -1 byte value (0xFF), equals the -1 EOF value (0xFFFFFFFF)

This simply added a casting to & 0xFF to avoid this confusion.

---

Progress

• JDK-8312475 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312475: org.jline.util.PumpReader signed byte problem (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3536/head:pull/3536
$ git checkout pull/3536

Update a local copy of the PR:
$ git checkout pull/3536
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3536

View PR using the GUI difftool:
$ git pr show -t 3536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3536.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Baraa-Hasheesh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @Baraa-Hasheesh This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a6c22efe)

[Baraa-Hasheesh]

/approval request Fixes a false reporting issue in SonarCloud due to confusion between -1(Byte) & -1(int) values. Applies cleanly. tier1 tests passes. Risk is minimal as no real change in code behaviour was made.

[openjdk]

@Baraa-Hasheesh
8312475: The approval request has been created successfully.

[Baraa-Hasheesh]

/approval request Solve a false reporting issue in SonarCloud due to confusion between -1(Byte) & -1(int) values, applies cleanly, tier1 tests passes.

[openjdk]

@Baraa-Hasheesh
8312475: The approval request has been updated successfully.