Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java #2975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 18, 2024

I backport this for parity with 17.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325762 needs maintainer approval

Issue

  • JDK-8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2975/head:pull/2975
$ git checkout pull/2975

Update a local copy of the PR:
$ git checkout pull/2975
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2975

View PR using the GUI difftool:
$ git pr show -t 2975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2975.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 41242cbe5d01fc6e19859626dd08f6191e7486fb 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant