-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303489: Add a test to verify classes in vmStruct have unique vtables #2926
base: master
Are you sure you want to change the base?
8303489: Add a test to verify classes in vmStruct have unique vtables #2926
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change is no longer ready for integration - check the PR body for details. |
This backport pull request has now been updated with issue from the original commit. |
|
Bug tail for JDK-8303489 includes JDK-8303921 and JDK-8311993. You'll probably want to backport them also. |
Hi @plummercj, thanks for pointing this out! As JDK-8311993 is new and not yet in 21, I'll postpone this for now. |
I backport this to improve testing in 17u
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2926/head:pull/2926
$ git checkout pull/2926
Update a local copy of the PR:
$ git checkout pull/2926
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2926/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2926
View PR using the GUI difftool:
$ git pr show -t 2926
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2926.diff
Webrev
Link to Webrev Comment