Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303489: Add a test to verify classes in vmStruct have unique vtables #2926

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 1, 2024

I backport this to improve testing in 17u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8303489 needs maintainer approval

Issue

  • JDK-8303489: Add a test to verify classes in vmStruct have unique vtables (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2926/head:pull/2926
$ git checkout pull/2926

Update a local copy of the PR:
$ git checkout pull/2926
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2926

View PR using the GUI difftool:
$ git pr show -t 2926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2926.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@GoeLin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport f9aadb943cb90382a631a5cafd0624d4e8a47789 8303489: Add a test to verify classes in vmStruct have unique vtables Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

@plummercj
Copy link
Contributor

Bug tail for JDK-8303489 includes JDK-8303921 and JDK-8311993. You'll probably want to backport them also.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 2, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 5, 2024

Hi @plummercj, thanks for pointing this out! As JDK-8311993 is new and not yet in 21, I'll postpone this for now.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants