Skip to content

8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Sep 19, 2024

The macos-11 github runners were deprecated and removed in June 2024 , making the macos tests to hang in openjdk11u-dev (and other OpenJDK repositories).

JDK-8335793 GHA: Bump macOS and Xcode versions upgraded the version from macos-11 to macos-13. This upgrade in github runners required a long list of changes in openjdk11u-dev that proved difficult to review.

In order to ease the review process this PR downgrades the version of github runners in jdk11u-dev from the current macos-13 to macos-12 and xcode-13.4.1. This will require a single backport of JDK-8299254 Support dealing with standard assert macro (a follow-up to this PR), making the review process easier.

Once the github actions are running again in macos-12 an upgrade to macos-13 could be performed, if required, with some more additional PRs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340671 needs maintainer approval

Issue

  • JDK-8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2936/head:pull/2936
$ git checkout pull/2936

Update a local copy of the PR:
$ git checkout pull/2936
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2936

View PR using the GUI difftool:
$ git pr show -t 2936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2936.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 19, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7144027dff495b623428bd9cd891c0ed912035a4 8318039: GHA: Bump macOS and Xcode versions Sep 19, 2024
@openjdk
Copy link

openjdk bot commented Sep 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 19, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK as a fix, but not under this bug. 8318039 is already in jdk11u-dev: https://git.openjdk.org/jdk11u-dev/commit/82e28669e7abbea30033d7b3e52c6b1fe5f4184a

Therefore, please open a JDK 11u specific bug and propose the fix under that new bug.

@vieiro vieiro changed the title 8318039: GHA: Bump macOS and Xcode versions 8318039: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Sep 23, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Sep 23, 2024

@jerboaa
Copy link
Contributor

jerboaa commented Sep 23, 2024

Filed as https://bugs.openjdk.org/browse/JDK-8318039

Still 8318039?

@vieiro vieiro changed the title 8318039: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 Sep 24, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Sep 24, 2024

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jerboaa
Copy link
Contributor

jerboaa commented Sep 24, 2024

On second thought, this PR is labelled backport. It's an 11u specific bug. Please close this PR and open a new - non-backport pr.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a 11u non-backport PR for this.

@vieiro vieiro closed this Sep 24, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Sep 24, 2024

Reopened as #2940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants