-
Notifications
You must be signed in to change notification settings - Fork 241
8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK as a fix, but not under this bug. 8318039
is already in jdk11u-dev
: https://git.openjdk.org/jdk11u-dev/commit/82e28669e7abbea30033d7b3e52c6b1fe5f4184a
Therefore, please open a JDK 11u specific bug and propose the fix under that new bug.
Still |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
On second thought, this PR is labelled backport. It's an 11u specific bug. Please close this PR and open a new - non-backport pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a 11u non-backport PR for this.
Reopened as #2940 |
The
macos-11
github runners were deprecated and removed in June 2024 , making themacos
tests to hang inopenjdk11u-dev
(and other OpenJDK repositories).JDK-8335793 GHA: Bump macOS and Xcode versions upgraded the version from
macos-11
tomacos-13
. This upgrade in github runners required a long list of changes inopenjdk11u-dev
that proved difficult to review.In order to ease the review process this PR downgrades the version of github runners in
jdk11u-dev
from the currentmacos-13
tomacos-12
andxcode-13.4.1
. This will require a single backport of JDK-8299254 Support dealing with standard assert macro (a follow-up to this PR), making the review process easier.Once the github actions are running again in
macos-12
an upgrade tomacos-13
could be performed, if required, with some more additional PRs.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2936/head:pull/2936
$ git checkout pull/2936
Update a local copy of the PR:
$ git checkout pull/2936
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2936/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2936
View PR using the GUI difftool:
$ git pr show -t 2936
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2936.diff
Webrev
Link to Webrev Comment