-
Notifications
You must be signed in to change notification settings - Fork 6k
8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114 #6962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….java after JDK-8278114
👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Trivial. (I'm not a Reviewer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and trivial.
Thanks for fixing it.
@xpbob This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 8b5de27. |
@DamonFool @xpbob Pushed as commit 8b5de27. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Didn't know about the rules about copyright years. Should we also make the same fix for https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/mulnode.cpp? |
Is there anything wrong with that file? |
I replaced 2021 with 2022 in #6675. I was wondering if we should do 2021, 2022 as well. |
No need I think. |
That makes perfect sense! Thanks. |
=>
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6962/head:pull/6962
$ git checkout pull/6962
Update a local copy of the PR:
$ git checkout pull/6962
$ git pull https://git.openjdk.java.net/jdk pull/6962/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6962
View PR using the GUI difftool:
$ git pr show -t 6962
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6962.diff