Skip to content

8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114 #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link
Contributor

@xpbob xpbob commented Jan 5, 2022

/*
 - * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
 + * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.

=>

 /*
- * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2021, 2022, Oracle and/or its affiliates. All rights reserved.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6962/head:pull/6962
$ git checkout pull/6962

Update a local copy of the PR:
$ git checkout pull/6962
$ git pull https://git.openjdk.java.net/jdk pull/6962/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6962

View PR using the GUI difftool:
$ git pr show -t 6962

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6962.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@xpbob The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@xpbob xpbob changed the title 8278114: Incorrect copyright year in compiler/lib/ir_framework/IRNode… 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode… Jan 5, 2022
@openjdk openjdk bot changed the title 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode… 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114 Jan 5, 2022
Copy link
Contributor

@shqking shqking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Trivial. (I'm not a Reviewer)

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and trivial.
Thanks for fixing it.

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java  after JDK-8278114

Reviewed-by: haosun, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2022
@xpbob
Copy link
Contributor Author

xpbob commented Jan 5, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@xpbob
Your change (at version 35219c6) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit 8b5de27.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@DamonFool @xpbob Pushed as commit 8b5de27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@CptGit
Copy link
Contributor

CptGit commented Jan 5, 2022

Didn't know about the rules about copyright years. Should we also make the same fix for https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/mulnode.cpp?

@DamonFool
Copy link
Member

Didn't know about the rules about copyright years. Should we also make the same fix for https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/mulnode.cpp?

Is there anything wrong with that file?
Or how would you like to fix it?

@CptGit
Copy link
Contributor

CptGit commented Jan 5, 2022

Didn't know about the rules about copyright years. Should we also make the same fix for https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/mulnode.cpp?

Is there anything wrong with that file? Or how would you like to fix it?

I replaced 2021 with 2022 in #6675. I was wondering if we should do 2021, 2022 as well.

@shqking
Copy link
Contributor

shqking commented Jan 5, 2022

Didn't know about the rules about copyright years. Should we also make the same fix for https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/mulnode.cpp?

Is there anything wrong with that file? Or how would you like to fix it?

I replaced 2021 with 2022 in #6675. I was wondering if we should do 2021, 2022 as well.

No need I think.
Per my understanding, AA, BB means this file was created in AA year, and lastly updated in BB year. If AA == BB, simply use AA.

@CptGit
Copy link
Contributor

CptGit commented Jan 5, 2022

That makes perfect sense! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants