8252661: Change SafepointMechanism terminology to talk less about "blocking" #54

fisk · 2020-09-07T12:33:37Z

Migrating this review from the mailing list into a pull request. So far, the favourite terminology is to talk about "process", but without "operation".

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8252661: Change SafepointMechanism terminology to talk less about "blocking"

Reviewers

Robbin Ehn (@robehn - Reviewer)
Aleksey Shipilev (@shipilev - Reviewer)
dholmes - Reviewer ⚠️ Added manually

Download

$ git fetch https://git.openjdk.java.net/jdk pull/54/head:pull/54
$ git checkout pull/54

…ocking"

bridgekeeper · 2020-09-07T12:35:39Z

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-07T12:36:47Z

@fisk The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-07T12:40:13Z

Webrevs

00: Full (5a57a8b)

shipilev · 2020-09-07T12:42:46Z

/review

openjdk · 2020-09-07T12:43:24Z

@shipilev Unknown command review - for a list of valid commands use /help.

shipilev · 2020-09-07T12:43:41Z

/reviewer shade

openjdk · 2020-09-07T12:43:57Z

@shipilev Only the author (@fisk) is allowed to issue the reviewer command.

shipilev · 2020-09-07T12:45:45Z

Okay, I am somewhat confused how Skara is supposed to register my review here. Reviewed!

robehn

I think we can do better than "process".
I can't think anything now, so ship it.

Thanks

openjdk · 2020-09-07T12:46:49Z

@fisk This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252661: Change SafepointMechanism terminology to talk less about "blocking"

Reviewed-by: rehn, shade, dholmes

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate e0c8d4420c8e1a84581927cf77314498b8e5aa52.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

fisk · 2020-09-07T13:04:07Z

Thanks for the reviews, @shipilev and @robehn. I'll add David Holmes as reviewer too, as the final name suggestion was his.

fisk · 2020-09-07T13:08:20Z

/reviewer dholmes

openjdk · 2020-09-07T13:08:55Z

@fisk Syntax: /reviewer (add|remove) [@user | openjdk-user]+. For example:

/reviewer add @openjdk-bot
/reviewer add duke
/reviewer add @user1 @user2

fisk · 2020-09-07T13:10:23Z

/reviewer add dholmes

openjdk · 2020-09-07T13:10:49Z

@fisk
Reviewer dholmes successfully added.

fisk · 2020-09-07T13:58:49Z

/integrate

openjdk · 2020-09-07T13:59:35Z

@fisk Pushed as commit e29c3f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Co-authored-by: Xin Liu <xxinliu@amazon.com>

* Update LICENSE file * The experimental version is aimed to refactor the tool * verificationType mistakenly added to source code is renamed to type * Adapted mvn bindings to at8 * Added tests to represent bad stream handling in jdec and correctone in jdis * Made jdec to write output to proper toolOutput instead of bad logOutput * 7903208: [Jasm] Add support for generics (the Signature attribute) * 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs * Replaced hardcoded String[] args, by varargs String... where reasonable Once the "tool" mandatory array memebr was removed from each tool's main method, and considering calls from libraries, and form tests where the argument is very often just one file, or more readable "a1", a2"... without new String[]{} declaration, changed those String[] enforcing headers to more benevolent String... * Intentionally removed ACC_SUPER class modifier was causing hotswap to fail When jasm's disasm, modify, asm cycle output binary was used for class hotswap, remote JDK was not accepting it with java.lang.UnsupportedOperationException: class redefinition failed: attempted to change the class modifiers beacuse of ommited supoer keyword (although it have already no real reason) This patch is returning the kwyword without conditions, when it was included in original bytecode * extended test to verify that super is not used always if super is not in source code, then it is not in disambled code * 7903248: jasm: FieldData.ConstantValue holds undefined reference to CP while writing fields to a class * Added support for stdin in jdis * stdin is now read also by jasm,jcod,jdec more tests needed * Removed jdis specific missleading provide method * Tool output moved where it belongs to commons * Removed duplicated declaration of ArrayList<ToolInput> fileList * Changed requireNonNull message in getDataInputStream * Added one more abstraction layer providing highly reusable byte[] based input * Properly exiting after verson is printed * Stream based inputs are now drained once needed, not during construction * reworked stdin read to be initiated by - As a side effect, files and stdin can be read together remove dduplicated code in tests by getting class in compile time added tests and adapted older to new behavior * added tests if asmtools assmble itself into valid bytecode Added two set of tests jdec->jcoder->load jdis->jasm->load Both in two variants, with -g, and without Both jdec->jcoder->load works fine Both jdis->jasm->load now fails on three files from 278: /org/openjdk/asmtools/jasm/JasmEnvironment$InputFile.class, /org/openjdk/asmtools/jcoder/Jcoder.class, /org/openjdk/asmtools/jasm/Parser.class Fail looks valid. Unluckily, the issue where -g disassembled and back assembled com.google.gson.Gson produce invalid bytecode was not hit The class BruteForceHelper is reusable for any set of classes * Naive fix for enforced dot.suffix * repalce stdout by configurable object This checkout is not buildable, but server as showcase for issue with dual logging for compilers * Replaced dualstream logger by wrapper so it can be later made fully customisable * Enabled shared i18n properties via reused asmtools/i18n.props * All four tools now use neww ToolOutput output As a consequence, all four tools by by default prints to stdout, and honours -d properly * Fixed typo which casued behavior regression found by unittests * Refatoed tests so they can harbour resources in maven way * Moved all logging to stderr. use -dls to return original behavior The -dls switch is oging to be removed once stderr is properl adapted * Implemented library-like input and output This commit is adding byte[]/String input/output clasases for direct library usage. Added tests, advertising how simple is usage of those inputs/outputs There are two hunks, which fixes issues ovberlooked in previous refactorings: - traceln now correctly calls getOutputs - jdec now uses proper logger insted of accidental stderr * Enabled -g for jcoder to be set from external code * Temporary workaround around tests being order-sensitive As -g is now making some disassmebld code not asemble-able back, and order of tests is not deterministic, and Options are static, thus if -g is now set in some test, it is not unset in other tests. Real fix is to move Options out of static context to context of environment as it is done for jcoder. * Added github actions Just for record for "act" for local testing. To run with podman based distros, several steps are ncessary. See nektos/act#303 ; especially * nektos/act#303 (comment) * and nektos/act#303 (comment) * the bind and socket eg: systemctl enable --now --user podman.socket systemctl start --user podman.socket export DOCKER_HOST=unix://$XDG_RUNTIME_DIR/podman/podman.sock ../act/bin/act --bind --container-daemon-socket $XDG_RUNTIME_DIR/podman/podman.sock To rerun the build on clean env, you have to stop and start the podman socket again Without explicit 'mvn test' the tests are not running. Not sure why * 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs * Fixed issue when jasm produced only one file from source with multiple ones Added tests for this issue Added test veryfying that the jcoder is not affected * 7903401: jtreg fails if set of jdk tests process jasm,jdis files with defects * 7903402: jdis: tool writes incorrect StackMapTable if the first same_frame has type 0 (openjdk#51) * 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs * 7903401: jtreg fails if set of jdk tests process jasm,jdis files with defects * 7903402: jdis: tool writes incorrect StackMapTable if the first same_frame has type 0 * 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs * Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces (openjdk#53) * Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces * Removed unused imports * Added licence headers * Added ajvadoc description to three main interfaces. * Removed unnecessary guard condition before changging \ to / for fqn * Replaced "\n" by System.lineSeparator() * Used better names for highlighted abbrevations * 7903405: compiler does not warn about instruction arguments that exceed allowed limits (openjdk#54) * 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs * 7903401: jtreg fails if set of jdk tests process jasm,jdis files with defects * 7903402: jdis: tool writes incorrect StackMapTable if the first same_frame has type 0 * 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs * 7903405: compiler does not warn about instruction arguments that exceed allowed limits * 7903405: compiler does not warn about instruction arguments that exceed allowed limits * Delete ToolOutput.java * Fixed junit test for CODETOOLS-7903405 (openjdk#56) * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 (openjdk#57) * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * Fix tabs * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 (Part II) (openjdk#58) * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * Fix tabs * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * CODETOOLS-7903506: Asmtools: jdis prints BootstrapMethod attribute if detailed output is off (openjdk#59) * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * Fix tabs * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903506: Asmtools: jdis prints BootstrapMethod attribute if detailed output is off * 7903509: jcoder, jasm: add option to override class file version in source file(s) (openjdk#60) * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * Fix tabs * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903509: jcoder, jasm: add option to override class file version in source file(s) * CODETOOLS-7903531: jdis: Suppress printing comments by adding an option (openjdk#61) * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * Fix tabs * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903458: Umbrella: Preparations for switching to Asmtools 8.0 * 7903531: jdis: Suppress printing comments by adding an option --------- Co-authored-by: Jiri Vanek <jvanek@redhat.com>

8252661: Change SafepointMechanism terminology to talk less about "bl…

5a57a8b

…ocking"

openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020

openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 7, 2020

robehn approved these changes Sep 7, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2020

shipilev approved these changes Sep 7, 2020

View reviewed changes

openjdk bot closed this Sep 7, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 7, 2020

openjdk bot removed the rfr Pull request is ready for review label Sep 7, 2020

caojoshua pushed a commit to caojoshua/jdk that referenced this pull request Jul 13, 2023

JVM-2172: [PEA] compilation crash in Dacapo/Eclipse. (openjdk#54)

9de2f82

Co-authored-by: Xin Liu <xxinliu@amazon.com>

robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023

Update rivos/gitlab-ci.yml file (openjdk#54)

84f30ba

mgronlun mentioned this pull request Nov 5, 2024

8342105: JVM Crash when Jacoco and JFR are active #21902

Closed

3 tasks

8252661: Change SafepointMechanism terminology to talk less about "blocking" #54

8252661: Change SafepointMechanism terminology to talk less about "blocking" #54

Uh oh!

Conversation

fisk commented Sep 7, 2020 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Download

Uh oh!

bridgekeeper bot commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

mlbridge bot commented Sep 7, 2020

Webrevs

Uh oh!

shipilev commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

shipilev commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

shipilev commented Sep 7, 2020

Uh oh!

robehn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fisk commented Sep 7, 2020

Uh oh!

fisk commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

fisk commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

fisk commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

fisk commented Sep 7, 2020 •

edited by openjdk bot

Loading

robehn left a comment •

edited

Loading

openjdk bot commented Sep 7, 2020 •

edited

Loading