8390506: Several JMH benchmarks fail with java.lang.NullPointerException

[lgxbslgx]

Hi all,

This patch adjusts several package names from the double corelibs (.corelibs.corelibs) to a simple corelibs and fixes the package names of the param fields (adding sandbox. in the middle). Then the java.lang.NullPointerException of the issue can be solved.

Best Regards,
-- Guoxiong

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8390506: Several JMH benchmarks fail with java.lang.NullPointerException (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32423/head:pull/32423
$ git checkout pull/32423

Update a local copy of the PR:
$ git checkout pull/32423
$ git pull https://git.openjdk.org/jdk.git pull/32423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32423

View PR using the GUI difftool:
$ git pr show -t 32423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32423.diff

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@lgxbslgx To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• net
• nio
• security
• serviceability
• shenandoah

[lgxbslgx]

/label add core-libs

[openjdk]

@lgxbslgx
The core-libs label was successfully added.

[lgxbslgx]

After fixing this issue JDK-8390506, a new error occurs (shown below). It seems a bug in org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.HashMap.

java.lang.NullPointerException: Cannot invoke "org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.HashMap$YNode.isEmpty()" because "entry" is null
	at org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.HashMap.putVal(HashMap.java:686)
	at org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.HashMap.put(HashMap.java:657)
	at org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.HashMapToArray.setup(HashMapToArray.java:81)
	at org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.jmh_generated.HashMapToArray_testKeySetToArray_jmhTest._jmh_tryInit_f_hashmaptoarray0_0(HashMapToArray_testKeySetToArray_jmhTest.java:347)
	at org.openjdk.bench.valhalla.sandbox.corelibs.mapprotos.jmh_generated.HashMapToArray_testKeySetToArray_jmhTest.testKeySetToArray_AverageTime(HashMapToArray_testKeySetToArray_jmhTest.java:140)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:583)
	at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:527)
	at org.openjdk.jmh.runner.BenchmarkHandler$BenchmarkTask.call(BenchmarkHandler.java:504)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:330)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:545)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:330)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614)
	at java.base/java.lang.Thread.run(Thread.java:1527)