Skip to content

8390499: Clean up suspicious bailout in ciMethod::find_monomorphic_target - #32412

Open
merykitty wants to merge 2 commits into
openjdk:masterfrom
merykitty:defaultdevirtualize
Open

8390499: Clean up suspicious bailout in ciMethod::find_monomorphic_target#32412
merykitty wants to merge 2 commits into
openjdk:masterfrom
merykitty:defaultdevirtualize

Conversation

@merykitty

@merykitty merykitty commented Aug 18, 2026

Copy link
Copy Markdown
Member

Hi,

This PR removes a suspicious place where we bail out of devirtualization. It is suspicious because it is either unnecessary, or it is too late as we have returned root_m in various places. Looking at Dependencies::find_unique_concrete_method, it is also clear that the implementation does not look at the name or the signature, but the vtable or itable index of the method to decide that it is the correct target.

Testing:

  • tier1-4,hs-comp-stress

Please take a look and let me know what you think, thanks a lot.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8390499: Clean up suspicious bailout in ciMethod::find_monomorphic_target (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32412/head:pull/32412
$ git checkout pull/32412

Update a local copy of the PR:
$ git checkout pull/32412
$ git pull https://git.openjdk.org/jdk.git pull/32412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32412

View PR using the GUI difftool:
$ git pr show -t 32412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32412.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 18, 2026

Copy link
Copy Markdown

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 18, 2026
@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

@merykitty The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 18, 2026
@mlbridge

mlbridge Bot commented Aug 18, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant