8390499: Clean up suspicious bailout in ciMethod::find_monomorphic_target - #32412
8390499: Clean up suspicious bailout in ciMethod::find_monomorphic_target#32412merykitty wants to merge 2 commits into
Conversation
|
👋 Welcome back qamai! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@merykitty The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Hi,
This PR removes a suspicious place where we bail out of devirtualization. It is suspicious because it is either unnecessary, or it is too late as we have returned
root_min various places. Looking atDependencies::find_unique_concrete_method, it is also clear that the implementation does not look at the name or the signature, but thevtableoritableindex of the method to decide that it is the correct target.Testing:
Please take a look and let me know what you think, thanks a lot.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32412/head:pull/32412$ git checkout pull/32412Update a local copy of the PR:
$ git checkout pull/32412$ git pull https://git.openjdk.org/jdk.git pull/32412/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32412View PR using the GUI difftool:
$ git pr show -t 32412Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32412.diff
Using Webrev
Link to Webrev Comment