8390432: Zero i386 build broken after JDK-8389219 - #32405
Conversation
|
👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into |
|
@vpa1977 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
I would say this is trivial and can be in with a single review. |
|
/integrate |
|
@vpa1977 This pull request has not yet been marked as ready for integration. |
|
/reviewers 1 |
|
Say |
|
/integrate |
This PR adds
#ifdefstatements aroundFLAG_SET_ERGO(UseCompressedOops, false);.UseCompressedOpsis a boolean constant in 32 bit build.The build fails due to https://bugs.openjdk.org/browse/JDK-8390159.
After applying the patch for https://bugs.openjdk.org/browse/JDK-8390159
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32405/head:pull/32405$ git checkout pull/32405Update a local copy of the PR:
$ git checkout pull/32405$ git pull https://git.openjdk.org/jdk.git pull/32405/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32405View PR using the GUI difftool:
$ git pr show -t 32405Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32405.diff
Using Webrev
Link to Webrev Comment