Skip to content

8390432: Zero i386 build broken after JDK-8389219 - #32405

Open
vpa1977 wants to merge 1 commit into
openjdk:masterfrom
vpa1977:JDK-8390432
Open

8390432: Zero i386 build broken after JDK-8389219#32405
vpa1977 wants to merge 1 commit into
openjdk:masterfrom
vpa1977:JDK-8390432

Conversation

@vpa1977

@vpa1977 vpa1977 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR adds #ifdef statements around FLAG_SET_ERGO(UseCompressedOops, false);. UseCompressedOps is a boolean constant in 32 bit build.

bash configure --disable-warnings-as-errors --with-jvm-variants=zero --disable-precompiled-headers

...
A new configuration has been successfully created in
/home/vladimirp/work/git/jdk/build/linux-x86-zero-release
using configure arguments '--disable-warnings-as-errors --with-jvm-variants=zero'.


Configuration summary:
* Name:           linux-x86-zero-release
* Debug level:    release
* HS debug level: product
* JVM variants:   zero
* JVM features:   zero: 'cds dtrace epsilongc g1gc jni-check jvmti management parallelgc serialgc services shenandoahgc vm-structs zero' 
* OpenJDK target: OS: linux, CPU architecture: x86, address length: 32
* Version string: 28-internal-adhoc.vladimirp.jdk (28-internal)
* Source date:    1787005914 (2026-08-17T22:31:54Z)

Tools summary:
* Boot JDK:       openjdk version "27-ea" 2026-09-15 OpenJDK Runtime Environment (build 27-ea+34-1-Debian) OpenJDK Zero VM (build 27-ea+34-1-Debian, interpreted mode, sharing) (at /usr/lib/jvm/java-27-openjdk-i386)
* Toolchain:      gcc (GNU Compiler Collection)
* C Compiler:     Version 16.2.0 (at /usr/bin/gcc)
* C++ Compiler:   Version 16.2.0 (at /usr/bin/g++)

Build performance summary:
* Build jobs:     32
* Memory limit:   62150 MB

...
make images CONF=linux-x86-zero-release
Building target 'images' in configuration 'linux-x86-zero-release'
....
Creating jdk/modules/jdk.jpackage/jdk/jpackage/internal/resources/jpackageapplauncher from 3 file(s)
Creating jdk/modules/jdk.jpackage/jdk/jpackage/internal/resources/libjpackageapplauncheraux.so from 19 file(s)
Error: Unable to load main class com.sun.tools.javac.Main in module jdk.compiler
Caused by: java.lang.VerifyError
gmake[3]: *** [modules/jdk.compiler/Gendata.gmk:60: /home/vladimirp/work/git/jdk/build/linux-x86-zero-release/buildtools/create_symbols_javac/_the.COMPILE_CREATE_SYMBOLS_batch] Error 1
gmake[2]: *** [make/Main.gmk:136: jdk.compiler-gendata] Error 2

ERROR: Build failed for target 'images' in configuration 'linux-x86-zero-release' (exit code 2)
Stopping javac server

=== Output from failing command(s) repeated here ===
* For target buildtools_create_symbols_javac__the.COMPILE_CREATE_SYMBOLS_batch:
Error: Unable to load main class com.sun.tools.javac.Main in module jdk.compiler
Caused by: java.lang.VerifyError

* All command lines available in /home/vladimirp/work/git/jdk/build/linux-x86-zero-release/make-support/failure-logs.
=== End of repeated output ===

No indication of failed target found.
HELP: Try searching the build log for '] Error'.
HELP: Run 'make doctor' to diagnose build problems.

make[1]: *** [/home/vladimirp/work/git/jdk/make/Init.gmk:151: main] Error 2
make: *** [/home/vladimirp/work/git/jdk/make/PreInit.gmk:160: images] Error 2

The build fails due to https://bugs.openjdk.org/browse/JDK-8390159.

After applying the patch for https://bugs.openjdk.org/browse/JDK-8390159

Creating CDS archive for jdk image for zero
Finished building target 'images' in configuration 'linux-x86-zero-release'


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8390432: Zero i386 build broken after JDK-8389219 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32405/head:pull/32405
$ git checkout pull/32405

Update a local copy of the PR:
$ git checkout pull/32405
$ git pull https://git.openjdk.org/jdk.git pull/32405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32405

View PR using the GUI difftool:
$ git pr show -t 32405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32405.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 17, 2026

Copy link
Copy Markdown

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 17, 2026

Copy link
Copy Markdown

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8390432: Zero i386 build broken after JDK-8389219

Reviewed-by: shade

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Aug 17, 2026
@openjdk

openjdk Bot commented Aug 17, 2026

Copy link
Copy Markdown

@vpa1977 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk

openjdk Bot commented Aug 17, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@vpa1977
vpa1977 marked this pull request as ready for review August 18, 2026 01:26
@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 18, 2026
@mlbridge

mlbridge Bot commented Aug 18, 2026

Copy link
Copy Markdown

Webrevs

@shipilev shipilev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, of course.

@shipilev

Copy link
Copy Markdown
Member

I would say this is trivial and can be in with a single review.

@vpa1977

vpa1977 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

@vpa1977 This pull request has not yet been marked as ready for integration.

@shipilev

Copy link
Copy Markdown
Member

/reviewers 1

@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

@shipilev
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Aug 18, 2026
@shipilev

Copy link
Copy Markdown
Member

Say /integrate again, @vpa1977

@vpa1977

vpa1977 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Aug 18, 2026
@openjdk

openjdk Bot commented Aug 18, 2026

Copy link
Copy Markdown

@vpa1977
Your change (at version e8c1660) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

2 participants