8382582: Remove the experimental JVMCI feature

[mhaessig]

This PR removes the experimental JVMCI feature and all usages and references of it, including references to Graal. For more details on the rationale, please see the issue description.

This change was constructed in several steps:

1. Remove all folders directly related to JVMCI.
2. Go through one folder at a time and remove code relating to matches for the regex ([Jj][Vv][Mm][Cc][Ii])|([Gg]raal)|vm\.ci|[Gg]alahad and immediately obvious dead code.
3. Filter the git blame for each file for JVMCI related commits and check if that code is now dead.

Note to Reviewers

Each commit is limited to a subfolder or a change spanning further so you can take look at a piece of the codebase you are familiar with. I recommend you look at individual commits and select "Ignore Whitespace" in the Github UI.

Testing

• Github Actions
• tier1-6 linux-x64, linux-aarch64, windows-x64, macosx-aarch64, macosx-x64
• build linux-zero, linux-arm, linux-riscv, linux-ppc (LE & BE) fastdebug with features C1+C2, C2 only, C1 only

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8385105 to be approved
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

• JDK-8382582: Remove the experimental JVMCI feature (Enhancement - P4)
• JDK-8385105: Remove the experimental JVMCI feature (CSR)

Reviewers

• Chen Liang (@liach - Reviewer) Review applies to 124e8824
• Stefan Karlsson (@stefank - Reviewer) Review applies to 3ab2183a
• Coleen Phillimore (@coleenp - Reviewer) Review applies to 3f822c8f
• Erik Joelsson (@erikj79 - Reviewer) Review applies to 0100264f
• Vladimir Kozlov (@vnkozlov - Reviewer)
• Vladimir Ivanov (@iwanowww - Reviewer) Review applies to 3f822c8f
• Chris Plummer (@plummercj - Reviewer) Review applies to 3f822c8f
• Alan Bateman (@AlanBateman - Reviewer) Review applies to 3f822c8f
• Tobias Hartmann (@TobiHartmann - Reviewer)

Contributors

• Tobias Hartmann <thartmann@openjdk.org>
• Mikael Vidstedt <mikael@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30834/head:pull/30834
$ git checkout pull/30834

Update a local copy of the PR:
$ git checkout pull/30834
$ git pull https://git.openjdk.org/jdk.git pull/30834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30834

View PR using the GUI difftool:
$ git pr show -t 30834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30834.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mhaessig]

/contributor add @TobiHartmann
/contributor add @vidmik

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382582: Remove the experimental JVMCI feature

Co-authored-by: Tobias Hartmann <thartmann@openjdk.org>
Co-authored-by: Mikael Vidstedt <mikael@openjdk.org>
Reviewed-by: kvn, thartmann, liach, stefank, coleenp, erikj, vlivanov, cjplummer, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 5ccfb15: 8316465: 10 nsk debugger tests ignore VM flags while starting debugee
• bbcd985: 8384958: Regression of jvmti/init/GetAllStackTraces/getallstktr001.java caused by JDK-8382273

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mhaessig
Contributor Tobias Hartmann <thartmann@openjdk.org> successfully added.

[openjdk]

@mhaessig
Contributor Mikael Vidstedt <mikael@openjdk.org> successfully added.

[openjdk]

@mhaessig The following labels will be automatically applied to this pull request:

• build
• compiler
• core-libs
• hotspot
• ide-support
• javadoc
• net
• nio
• security
• serviceability
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[liach]

Core library changes look fine.

[wangweij]

/label remove security

[openjdk]

@wangweij
The security label was successfully removed.

[openjdk]

@mhaessig this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout remove-jvmci
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[vnkozlov]

I don't know if we want to remove this file or do the jdk.jsobject-style removal in the symbols - it might be okay for us to nuke these internal modules this way.

I think removing the files for JDK releases from "M" (i.e. 22) through "R" (i.e. 27) i needs some more consideration, Removing the files in the current release is much less problematic.

Note, JVMCI was always JDK internal experimental feature. javac --release applies to public Java API

I am not sure what the goal of CSR will be here.

[vnkozlov]

CSR: https://bugs.openjdk.org/browse/JDK-8385105

[liach]

Removal of the javac symbol files should be fine. javac's --add-modules already does not work with --release for these removed modules.

[vnkozlov]

Good.

[TobiHartmann]

Looks good to me.

[vnkozlov]

Still good.

[mhaessig]

Thank you all for reviewing! An additional round of testing tiers 1 through 5 passed all green.

/integrate

[openjdk]

Going to push as commit 2acf0dc.
Since your change was applied there have been 2 commits pushed to the master branch:

• 5ccfb15: 8316465: 10 nsk debugger tests ignore VM flags while starting debugee
• bbcd985: 8384958: Regression of jvmti/init/GetAllStackTraces/getallstktr001.java caused by JDK-8382273

Your commit was automatically rebased without conflicts.

[openjdk]

@mhaessig Pushed as commit 2acf0dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.