Skip to content

8382103: Shenandoah: Optimize ShenandoahLock size for release build#30728

Open
pf0n wants to merge 5 commits intoopenjdk:masterfrom
pf0n:8382103
Open

8382103: Shenandoah: Optimize ShenandoahLock size for release build#30728
pf0n wants to merge 5 commits intoopenjdk:masterfrom
pf0n:8382103

Conversation

@pf0n
Copy link
Copy Markdown

@pf0n pf0n commented Apr 14, 2026

The ShenandoahLock class members: _owner and shenandoah_padding(2) are only used in debug builds, but they will appear in the release build. Used ASSERT and DEBUG_ONLY macro, so they no longer appear in the release build.

Testing:

test/hotspot/jtreg/gc/shenandoah (all passed)



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8382103: Shenandoah: Optimize ShenandoahLock size for release build (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30728/head:pull/30728
$ git checkout pull/30728

Update a local copy of the PR:
$ git checkout pull/30728
$ git pull https://git.openjdk.org/jdk.git pull/30728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30728

View PR using the GUI difftool:
$ git pr show -t 30728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30728.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 14, 2026

👋 Welcome back pf0n! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Apr 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

@pf0n The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 14, 2026

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 14, 2026
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2026
@pf0n pf0n requested a review from pengxiaolong April 14, 2026 22:14
Copy link
Copy Markdown

@pengxiaolong pengxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants