Skip to content

8374629: Type test pattern with array type in switch fails to parse#30721

Open
biboudis wants to merge 1 commit intoopenjdk:masterfrom
biboudis:JDK-8374629
Open

8374629: Type test pattern with array type in switch fails to parse#30721
biboudis wants to merge 1 commit intoopenjdk:masterfrom
biboudis:JDK-8374629

Conversation

@biboudis
Copy link
Copy Markdown
Member

@biboudis biboudis commented Apr 14, 2026

The parser was too strict when parsing > in the classification of a label on whether it is an expression or pattern. There are still occasions that after an [ or an @ an expression may follow. This PR addresses this issue.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374629: Type test pattern with array type in switch fails to parse (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30721/head:pull/30721
$ git checkout pull/30721

Update a local copy of the PR:
$ git checkout pull/30721
$ git pull https://git.openjdk.org/jdk.git pull/30721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30721

View PR using the GUI difftool:
$ git pr show -t 30721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30721.diff

Using Webrev

Link to Webrev Comment

@biboudis biboudis marked this pull request as ready for review April 14, 2026 14:15
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 14, 2026

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Apr 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 14, 2026

@biboudis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 14, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant