8382150: Shenandoah: Clean up nmethod entry barrier support#30717
Open
shipilev wants to merge 1 commit intoopenjdk:masterfrom
Open
8382150: Shenandoah: Clean up nmethod entry barrier support#30717shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
| ShenandoahNMethodTable* ShenandoahCodeRoots::_nmethod_table; | ||
| int ShenandoahCodeRoots::_disarmed_value = 1; | ||
|
|
||
| bool ShenandoahCodeRoots::use_nmethod_barriers_for_mark() { |
Contributor
There was a problem hiding this comment.
Is there diagnostic value in having the capability to not use nmethod barriers? Would we ever turn them off for passive mode?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have this transitional method,
ShenandoahCodeRoots::use_nmethod_barriers_for_mark(), added back when nmethod entry barriers were a new features. But today, continuations are always on, and class unloading is also always on. So there is no point it running in the mode where nmethod entry barriers are disabled. This is a clean up that is useful in further optimizations past Late Barrier Expansion.Additionally,
ShenandoahNMethodserves as the wrapper over*NMethodBarrierSetcalls, so I cleaned up part of that interface as well.Additional testing:
hotspot_gc_shenandoahProgress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30717/head:pull/30717$ git checkout pull/30717Update a local copy of the PR:
$ git checkout pull/30717$ git pull https://git.openjdk.org/jdk.git pull/30717/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30717View PR using the GUI difftool:
$ git pr show -t 30717Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30717.diff
Using Webrev
Link to Webrev Comment