Skip to content

8382054: TestLoopPeelingDisabled.java fails with -DVerifyIR=false #30713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raneashay wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −3
Open

8382054: TestLoopPeelingDisabled.java fails with -DVerifyIR=false #30713

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75e7161
8382054: TestLoopPeelingDisabled.java fails with -DVerifyIR=false
raneashay Apr 13, 2026
81cfd81
Address PR comments
raneashay Apr 14, 2026
a40abca
Fix minor formatting error
raneashay Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/hotspot/jtreg/compiler/loopopts/TestLoopPeelingDisabled.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,16 @@ public static void main(String[] args) {

// Then, run the same test with loop peeling disabled, which should
// elide the {BEFORE,AFTER}_LOOP_PEELING compilation phases, causing the
// test to throw an IRViolationException. We then check whether the
// test to throw IRViolationException. We then check whether the
// exception message matches our expectation (that the loop peeling
// phase was not found).
// phase was not found). If IR verification is disabled, this test will
// not throw IRViolationException.
Copy link
Copy Markdown
Member

@chhagedorn chhagedorn Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// not throw IRViolationException.
// not throw an IRViolationException.

try {
TestFramework.runWithFlags("-XX:+UnlockDiagnosticVMOptions",
"-XX:LoopPeeling=0");
Asserts.fail("Expected IRViolationException");
String verifyIR = System.getProperty("VerifyIR", "true");
String msg = "Expected IRViolationException when performing IR matching";
Asserts.assertFalse(Boolean.parseBoolean(verifyIR), msg);
} catch (IRViolationException e) {
String info = e.getExceptionInfo();
if (!info.contains("NO compilation output found for this phase")) {
Expand Down