Skip to content

8380989: HttpRequest.Builder#headers() throws an exception if an empty array is passed #30708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vy wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −7
Open

8380989: HttpRequest.Builder#headers() throws an exception if an empty array is passed #30708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f05a5
Accept empty arrays in `java.net.http.HttpRequest.Builder#headers`
vy Apr 13, 2026
b5ede0a
Fix `RequestBuilderTest`
vy Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/java.net.http/share/classes/jdk/internal/net/http/HttpRequestBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -145,7 +145,7 @@ public HttpRequestBuilderImpl header(String name, String value) {
@Override
public HttpRequestBuilderImpl headers(String... params) {
requireNonNull(params);
if (params.length == 0 || params.length % 2 != 0) {
if (params.length % 2 != 0) {
throw newIAE("wrong number, %d, of parameters", params.length);
}
for (int i = 0; i < params.length; i += 2) {
Expand Down
6 changes: 3 additions & 3 deletions test/jdk/java/net/httpclient/HttpRequestBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -112,8 +112,8 @@ public static void main(String[] args) throws Exception {
builder = test1("headers", builder, builder::headers, (String[]) null,
NullPointerException.class);

builder = test1("headers", builder, builder::headers, new String[0],
IllegalArgumentException.class);
builder = test1("headers", builder, builder::headers, new String[0]
/* no expected exceptions */);

builder = test1("headers", builder, builder::headers,
(String[]) new String[] {null, "bar"},
Expand Down
3 changes: 1 addition & 2 deletions test/jdk/java/net/httpclient/RequestBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,10 @@ public void testMethod() {
public void testHeaders() {
HttpRequest.Builder builder = newBuilder(uri);

String[] empty = new String[0];
assertThrows(IAE, () -> builder.headers(empty).build());
assertThrows(IAE, () -> builder.headers("1").build());
assertThrows(IAE, () -> builder.headers("1", "2", "3").build());
assertThrows(IAE, () -> builder.headers("1", "2", "3", "4", "5").build());
assertEquals(0, builder.headers(new String[0]).build().headers().map().size());
assertEquals(0, builder.build().headers().map().size());

List<HttpRequest> requests = List.of(
Expand Down