8381898: SwitchBootstraps::typeSwitch() not accepting Float, Double types#30703
8381898: SwitchBootstraps::typeSwitch() not accepting Float, Double types#30703dbalek wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back dbalek! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
|
/csr |
|
@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request. @dbalek please create a CSR request for issue JDK-8381898 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java
Outdated
Show resolved
Hide resolved
|
/issue add JDK-8376162 |
|
@dbalek |
liach
left a comment
There was a problem hiding this comment.
Looks good, you can proceed to finalize the CSR too.
With the
SwitchBootstraps.typeSwitch(...)method, there is a specification issue (difference between what is written in the method's Javadoc and its actual behaviour) causing some JCK tests to fail.The proposal here is:
Adjust the Javadoc of the
SwitchBootstraps.typeSwitch(...)method to reflect the following changes in the behaviour of the method:targetto be of a reference type (primitive type targets are allowed now)labelsare allowed now if the preview features are enabledProgress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30703/head:pull/30703$ git checkout pull/30703Update a local copy of the PR:
$ git checkout pull/30703$ git pull https://git.openjdk.org/jdk.git pull/30703/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30703View PR using the GUI difftool:
$ git pr show -t 30703Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30703.diff
Using Webrev
Link to Webrev Comment