8252825: Add automated test for fix done in JDK-8218479 #30

pankaj-bansal · 2020-09-06T15:21:45Z

Under JDK-8218479, fix was made to correct the rendering of JTextPane as the background color of JTextPane was similar to Panel color, so it looked like the JTextPane has transparent background. No automated test was written to verify the results. Current bug is to write the automated tests for the same.

The test fails without the fix done in JDK-8218479 and pass with the fix. I have run the tests multiple times in mach5. Links in JBS.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8252825: Add automated test for fix done in JDK-8218479

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)
Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/30/head:pull/30
$ git checkout pull/30

bridgekeeper · 2020-09-06T15:23:33Z

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-06T15:24:28Z

@pankaj-bansal The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-06T15:27:21Z

Webrevs

00: Full (5adf955)

pankaj-bansal · 2020-09-06T15:46:08Z

/reviewer add @mrserb

openjdk · 2020-09-06T15:46:28Z

@pankaj-bansal
Reviewer serb successfully added.

openjdk · 2020-09-06T15:46:47Z

@pankaj-bansal This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252825: Add automated test for fix done in JDK-8218479

Reviewed-by: serb, prr

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

5f76deb: 8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5f76deb2e064ca8a48fb8a638c23aad34bf27f9c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

pankaj-bansal · 2020-09-06T15:49:28Z

/reviewer remove @mrserb

openjdk · 2020-09-06T15:49:37Z

@pankaj-bansal
Reviewer serb successfully removed.

pankaj-bansal · 2020-09-07T07:24:50Z

/integrate

openjdk · 2020-09-07T07:25:40Z

@pankaj-bansal Since your change was applied there has been 1 commit pushed to the master branch:

5f76deb: 8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor

Your commit was automatically rebased without conflicts.

Pushed as commit 55c7e76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JVM-1889: Materialize phi and its inputs if one input is escaped

Similarly to AArch64 DC.ZVA, the RISC-V Zicboz [1] extension provides the cbo.zero [2] instruction that allows to zero out memory a cache-line at a time. This should be faster than storing zeroes 64bits at a time. [1] https://github.com/riscv/riscv-CMOs [2] https://github.com/riscv/riscv-CMOs/blob/master/cmobase/Zicboz.adoc#insns-cbo_zero

@18

Verified by manually inserting an invalid opcode into a classfile. Replaced an opcode with the 'cf' opcode, which is invalid. The opcodes 'cb'-'fd' are unassigned and reserved for future use. Caused by: java.lang.VerifyError: Bad instruction: cf Exception Details: Location: MediumHarvestChurn.main([Ljava/lang/String;)V @56: fast_fgetfield Reason: Error exists in the bytecode Bytecode: 0000000: 2a03 32b8 0007 b600 0d3c bb00 1159 b700 0000010: 134e 1b9a 0006 a700 6a2d 1064 b200 1468 0000020: bc08 b600 1a57 a7ff ec3a 0403 3605 1505 0000030: 1020 a200 2803 3606 cf06 b200 20a2 0017 0000040: 2d15 05b2 0020 6815 0660 b600 2357 8406 0000050: 01a7 ffe7 8405 01a7 ffd7 b800 2706 b200 0000060: 2c68 bc08 4dbb 0011 59b7 0013 4e01 4db8 0000070: 0027 8401 ffb2 002f 1233 b600 35a7 ff95 0000080: b1 Exception Handler Table: bci [25, 38] => handler: 41 Stackmap Table: append_frame(@18,Integer,Top,Object[openjdk#17]) same_frame(@25) same_locals_1_stack_item_frame(@41,Object[openjdk#30]) append_frame(@46,Object[openjdk#30],Integer) append_frame(@56,Integer) chop_frame(@84,1) chop_frame(@90,1) chop_frame(@128,1)

@18

Verified by manually inserting an invalid opcode into a classfile. Replaced an opcode with the 'cf' opcode, which is invalid. The opcodes 'cb'-'fd' are unassigned and reserved for future use. Caused by: java.lang.VerifyError: Bad instruction: cf Exception Details: Location: MediumHarvestChurn.main([Ljava/lang/String;)V @56: fast_fgetfield Reason: Error exists in the bytecode Bytecode: 0000000: 2a03 32b8 0007 b600 0d3c bb00 1159 b700 0000010: 134e 1b9a 0006 a700 6a2d 1064 b200 1468 0000020: bc08 b600 1a57 a7ff ec3a 0403 3605 1505 0000030: 1020 a200 2803 3606 cf06 b200 20a2 0017 0000040: 2d15 05b2 0020 6815 0660 b600 2357 8406 0000050: 01a7 ffe7 8405 01a7 ffd7 b800 2706 b200 0000060: 2c68 bc08 4dbb 0011 59b7 0013 4e01 4db8 0000070: 0027 8401 ffb2 002f 1233 b600 35a7 ff95 0000080: b1 Exception Handler Table: bci [25, 38] => handler: 41 Stackmap Table: append_frame(@18,Integer,Top,Object[openjdk#17]) same_frame(@25) same_locals_1_stack_item_frame(@41,Object[openjdk#30]) append_frame(@46,Object[openjdk#30],Integer) append_frame(@56,Integer) chop_frame(@84,1) chop_frame(@90,1) chop_frame(@128,1)

@18

Verified by manually inserting an invalid opcode into a classfile. Replaced an opcode with the 'cf' opcode, which is invalid. The opcodes 'cb'-'fd' are unassigned and reserved for future use. Caused by: java.lang.VerifyError: Bad instruction: cf Exception Details: Location: MediumHarvestChurn.main([Ljava/lang/String;)V @56: fast_fgetfield Reason: Error exists in the bytecode Bytecode: 0000000: 2a03 32b8 0007 b600 0d3c bb00 1159 b700 0000010: 134e 1b9a 0006 a700 6a2d 1064 b200 1468 0000020: bc08 b600 1a57 a7ff ec3a 0403 3605 1505 0000030: 1020 a200 2803 3606 cf06 b200 20a2 0017 0000040: 2d15 05b2 0020 6815 0660 b600 2357 8406 0000050: 01a7 ffe7 8405 01a7 ffd7 b800 2706 b200 0000060: 2c68 bc08 4dbb 0011 59b7 0013 4e01 4db8 0000070: 0027 8401 ffb2 002f 1233 b600 35a7 ff95 0000080: b1 Exception Handler Table: bci [25, 38] => handler: 41 Stackmap Table: append_frame(@18,Integer,Top,Object[openjdk#17]) same_frame(@25) same_locals_1_stack_item_frame(@41,Object[openjdk#30]) append_frame(@46,Object[openjdk#30],Integer) append_frame(@56,Integer) chop_frame(@84,1) chop_frame(@90,1) chop_frame(@128,1)

@18

Verified by manually inserting an invalid opcode into a classfile. Replaced an opcode with the 'cf' opcode, which is invalid. The opcodes 'cb'-'fd' are unassigned and reserved for future use. Caused by: java.lang.VerifyError: Bad instruction: cf Exception Details: Location: MediumHarvestChurn.main([Ljava/lang/String;)V @56: fast_fgetfield Reason: Error exists in the bytecode Bytecode: 0000000: 2a03 32b8 0007 b600 0d3c bb00 1159 b700 0000010: 134e 1b9a 0006 a700 6a2d 1064 b200 1468 0000020: bc08 b600 1a57 a7ff ec3a 0403 3605 1505 0000030: 1020 a200 2803 3606 cf06 b200 20a2 0017 0000040: 2d15 05b2 0020 6815 0660 b600 2357 8406 0000050: 01a7 ffe7 8405 01a7 ffd7 b800 2706 b200 0000060: 2c68 bc08 4dbb 0011 59b7 0013 4e01 4db8 0000070: 0027 8401 ffb2 002f 1233 b600 35a7 ff95 0000080: b1 Exception Handler Table: bci [25, 38] => handler: 41 Stackmap Table: append_frame(@18,Integer,Top,Object[openjdk#17]) same_frame(@25) same_locals_1_stack_item_frame(@41,Object[openjdk#30]) append_frame(@46,Object[openjdk#30],Integer) append_frame(@56,Integer) chop_frame(@84,1) chop_frame(@90,1) chop_frame(@128,1)

…rriers Carriers update for matchers-experiment

8252825: Add automated test for fix done in JDK-8218479

5adf955

openjdk bot added the rfr Pull request is ready for review label Sep 6, 2020

openjdk bot added the swing client-libs-dev@openjdk.org label Sep 6, 2020

openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2020

openjdk bot removed the ready Pull request is ready to be integrated label Sep 6, 2020

mrserb approved these changes Sep 6, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2020

prrace approved these changes Sep 6, 2020

View reviewed changes

openjdk bot closed this Sep 7, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 7, 2020

openjdk bot removed the rfr Pull request is ready for review label Sep 7, 2020

pankaj-bansal deleted the JDK-8252825 branch September 7, 2020 07:27

asotona mentioned this pull request Sep 3, 2021

8268869: java in source-file mode suggests javac-only Xlint flags #4613

Closed

3 tasks

caojoshua pushed a commit to caojoshua/jdk that referenced this pull request May 8, 2023

Merge pull request openjdk#30 from navyxliu/PEA_parser

536ff0e

JVM-1889: Materialize phi and its inputs if one input is escaped

lahodaj pushed a commit to lahodaj/jdk that referenced this pull request Jul 9, 2025

Merge pull request openjdk#30 from lahodaj/matchers-experiment-new-ca…

619b4aa

…rriers Carriers update for matchers-experiment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8252825: Add automated test for fix done in JDK-8218479 #30

8252825: Add automated test for fix done in JDK-8218479 #30

Uh oh!

pankaj-bansal commented Sep 6, 2020 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020

Uh oh!

mlbridge bot commented Sep 6, 2020

Uh oh!

pankaj-bansal commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020 •

edited

Loading

Uh oh!

pankaj-bansal commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020

Uh oh!

pankaj-bansal commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

8252825: Add automated test for fix done in JDK-8218479 #30

8252825: Add automated test for fix done in JDK-8218479 #30

Uh oh!

Conversation

pankaj-bansal commented Sep 6, 2020 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Download

Uh oh!

bridgekeeper bot commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020

Uh oh!

mlbridge bot commented Sep 6, 2020

Webrevs

Uh oh!

pankaj-bansal commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pankaj-bansal commented Sep 6, 2020

Uh oh!

openjdk bot commented Sep 6, 2020

Uh oh!

pankaj-bansal commented Sep 7, 2020

Uh oh!

openjdk bot commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

pankaj-bansal commented Sep 6, 2020 •

edited by openjdk bot

Loading

openjdk bot commented Sep 6, 2020 •

edited

Loading