Skip to content

8378377: Remove use of AppContext from JEditorPane - #29855

Closed
prrace wants to merge 4 commits into
openjdk:masterfrom
prrace:ac_jedit
Closed

8378377: Remove use of AppContext from JEditorPane#29855
prrace wants to merge 4 commits into
openjdk:masterfrom
prrace:ac_jedit

Conversation

@prrace

@prrace prrace commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Remove AppContext from JEditorPane


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8378377: Remove use of AppContext from JEditorPane (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29855/head:pull/29855
$ git checkout pull/29855

Update a local copy of the PR:
$ git checkout pull/29855
$ git pull https://git.openjdk.org/jdk.git pull/29855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29855

View PR using the GUI difftool:
$ git pr show -t 29855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29855.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Feb 21, 2026

Copy link
Copy Markdown

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Feb 21, 2026

Copy link
Copy Markdown

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378377: Remove use of AppContext from JEditorPane

Reviewed-by: serb, dnguyen, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title 8378377 8378377: Remove use of AppContext from JEditorPane Feb 21, 2026
@openjdk openjdk Bot added the client client-libs-dev@openjdk.org label Feb 21, 2026
@openjdk

openjdk Bot commented Feb 21, 2026

Copy link
Copy Markdown

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 21, 2026
@mlbridge

mlbridge Bot commented Feb 21, 2026

Copy link
Copy Markdown

Webrevs

@prrace

prrace commented Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

@prsadhuk @DamonGuy please review

Comment thread src/java.desktop/share/classes/javax/swing/JEditorPane.java Outdated
Comment thread src/java.desktop/share/classes/javax/swing/JEditorPane.java Outdated

@DamonGuy DamonGuy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now. There may be merit to removing getKitRegistry method but it's used a couple times throughout and would require additional changes as well.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Feb 24, 2026

@prsadhuk prsadhuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk Bot removed the ready Pull request is ready to be integrated label Feb 24, 2026
Comment thread src/java.desktop/share/classes/javax/swing/JEditorPane.java
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Feb 26, 2026
@prrace

prrace commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented Feb 26, 2026

Copy link
Copy Markdown

Going to push as commit 71a1af7.
Since your change was applied there have been 94 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Feb 26, 2026
@openjdk openjdk Bot closed this Feb 26, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2026
@openjdk

openjdk Bot commented Feb 26, 2026

Copy link
Copy Markdown

@prrace Pushed as commit 71a1af7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants