8349192: jvmti/scenarios/contention/TC05/tc05t001 fails: ERROR: tc05t001.cpp, 281: (waitedThreadCpuTime - waitThreadCpuTime) < (EXPECTED_ACCURACY * 1000000) #28206
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tc05t001.cpp, 281: (waitedThreadCpuTime - waitThreadCpuTime) < (EXPECTED_ACCURACY * 1000000)
|
👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
sspitsyn
changed the title
sendaoYan
reviewed
Nov 8, 2025
| @@ -40,9 +40,9 @@ static const jlong EXPECTED_TIMEOUT = 1; | |||
| static const jlong EXPECTED_TIMEOUT_ACCURACY_NS = 300000; | |||
|
|
|||
| #if (defined(WIN32) || defined(_WIN32)) | |||
| static const jlong EXPECTED_ACCURACY = 16; // 16ms is longest clock update interval | |||
| static const jlong EXPECTED_ACCURACY = 32; // 16ms is longest clock update interval | |||
Member
There was a problem hiding this comment.
Does the comment 16ms should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix is to increase the
EXPECTED_ACCURACYvalue in the test:hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/TC05/tc05t001.It is used check that the waiting time between
MonitorWaitandMonitorWaitedevent is not big. It seems that in some corner cases this time can be bigger than expected.Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28206/head:pull/28206$ git checkout pull/28206Update a local copy of the PR:
$ git checkout pull/28206$ git pull https://git.openjdk.org/jdk.git pull/28206/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28206View PR using the GUI difftool:
$ git pr show -t 28206Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28206.diff
Using Webrev
Link to Webrev Comment