8371436: (fs) java/nio/file/FileStore/Basic.java fails on macOS platform due to assertTrue(!store.equals(prev));

[bplb]

In BsdNativeDispatcher.fsstatEntry(), initialize the UnixMountEntry field dev, which propagates to UnixFileStore and is used in the latter's equals method, which BsdFileStore does not override.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371436: (fs) java/nio/file/FileStore/Basic.java fails on macOS platform due to assertTrue(!store.equals(prev)); (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28205/head:pull/28205
$ git checkout pull/28205

Update a local copy of the PR:
$ git checkout pull/28205
$ git pull https://git.openjdk.org/jdk.git pull/28205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28205

View PR using the GUI difftool:
$ git pr show -t 28205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28205.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

It was found in testing on the node where the failure was observed, that the test FileStore/Basic.java continued to fail without this change, but succeeded with it.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371436: (fs) java/nio/file/FileStore/Basic.java fails on macOS platform due to assertTrue(!store.equals(prev));

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

• 066810c: 8371485: ProblemList awt/Mixing/AWT_Mixing/JTableInGlassPaneOverlapping.java for linux
• 2c3c470: 8354548: Update CLDR to Version 48.0
• 9bc2360: 8371364: Refactor javax/swing/JFileChooser/FileSizeCheck.java to use Util.findComponent()
• ... and 58 more: https://git.openjdk.org/jdk/compare/c6a88155b519a5d0b22f6009e75a0e6388601756...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c9ce7dfa)

[AlanBateman]

So the dev field has always been 0, I assume this goes back to the original port to macOS in JDK 7u.