-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8371284: GenShen: Avoid unnecessary card marking #28204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back nityarai08! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@nityarai08 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
earthling-amzn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure we don't mark cards for null objects.
Exclude young-young, old-old and honor UseCondCardMark in dirty card marking.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28204/head:pull/28204$ git checkout pull/28204Update a local copy of the PR:
$ git checkout pull/28204$ git pull https://git.openjdk.org/jdk.git pull/28204/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28204View PR using the GUI difftool:
$ git pr show -t 28204Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28204.diff
Using Webrev
Link to Webrev Comment