Skip to content

Conversation

@nityarai08
Copy link

@nityarai08 nityarai08 commented Nov 7, 2025

Exclude young-young, old-old and honor UseCondCardMark in dirty card marking.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371284: GenShen: Avoid unnecessary card marking (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28204/head:pull/28204
$ git checkout pull/28204

Update a local copy of the PR:
$ git checkout pull/28204
$ git pull https://git.openjdk.org/jdk.git pull/28204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28204

View PR using the GUI difftool:
$ git pr show -t 28204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28204.diff

Using Webrev

Link to Webrev Comment

@nityarai08 nityarai08 changed the title 8371284 : GenShen: Avoid unnecessary card marking 8371284: GenShen: Avoid unnecessary card marking Nov 7, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back nityarai08! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Nov 7, 2025
@openjdk
Copy link

openjdk bot commented Nov 7, 2025

@nityarai08 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we don't mark cards for null objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants