Skip to content

8371474: Wrong object class or methodID passed to JNI call in TestSharedCloseJvmti with -Xshare:off #28202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −5
Open

8371474: Wrong object class or methodID passed to JNI call in TestSharedCloseJvmti with -Xshare:off #28202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/jdk/java/foreign/sharedclosejvmti/TestSharedCloseJvmti.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ public static class EventDuringScopedAccessRunner {

static final CountDownLatch MAIN_LATCH = new CountDownLatch(1);
static final CountDownLatch TARGET_LATCH = new CountDownLatch(1);
static final MemorySegment OTHER_SEGMENT = Arena.global().allocate(4);

static volatile int SINK;

Expand Down Expand Up @@ -107,7 +106,9 @@ private static void target() {
addFrames(0);
} else {
reentrant = true;
SINK = OTHER_SEGMENT.get(ValueLayout.JAVA_INT, 0);
try (Arena arena = Arena.ofConfined()) {
SINK = arena.allocate(4).get(ValueLayout.JAVA_INT, 0);
}
reentrant = false;
}
}
Expand Down
6 changes: 3 additions & 3 deletions test/jdk/java/foreign/sharedclosejvmti/libSharedCloseAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ static const char* TARGET_METHOD_SIG = "()V";
static const char* INTERCEPT_CLASS_NAME = "Ljdk/internal/foreign/MemorySessionImpl;";
static const char* INTERCEPT_METHOD_NAME = "checkValidStateRaw";

void start(jvmtiEnv *jvmti_env, JNIEnv* jni_env) {
void start(jvmtiEnv*, JNIEnv* jni_env, jthread) {

jclass cls = jni_env->FindClass(TARGET_CLASS_NAME);
if (cls == nullptr) {
Expand Down Expand Up @@ -111,7 +111,7 @@ Agent_OnLoad(JavaVM *vm, char *options, void *reserved) {
}

jvmtiEventCallbacks callbacks;
callbacks.VMStart = start;
callbacks.VMInit = start;
callbacks.MethodExit = method_exit;

err = env->SetEventCallbacks(&callbacks, (jint) sizeof(callbacks));
Expand All @@ -124,7 +124,7 @@ Agent_OnLoad(JavaVM *vm, char *options, void *reserved) {
return err;
}

err = env->SetEventNotificationMode(JVMTI_ENABLE, JVMTI_EVENT_VM_START, nullptr);
err = env->SetEventNotificationMode(JVMTI_ENABLE, JVMTI_EVENT_VM_INIT, nullptr);
if (err != JVMTI_ERROR_NONE) {
return err;
}
Expand Down