8370966: Create regression test for the hierarchical memory limit fix in JDK-8370572 #28201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this test-only enhancement. It creates a regression test for the Amazon ECS setup on cgroups v1 where the parent memory limit isn't visible inside the container and, thus, needs to rely on the cg v1 specific
hierarchical_memory_limittoken inmemory.stat. The proposed test is cg v1 only and needs to be run as root. It's skipped otherwise. It's useful to have when working on refactorings like #27743 so as not to regress.The other changes are an effort to reduce code duplication in the test code where similar patterns have been used in other container tests.
Testing (all on Linux x86_64):
Thoughts?
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28201/head:pull/28201$ git checkout pull/28201Update a local copy of the PR:
$ git checkout pull/28201$ git pull https://git.openjdk.org/jdk.git pull/28201/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28201View PR using the GUI difftool:
$ git pr show -t 28201Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28201.diff
Using Webrev
Link to Webrev Comment