8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2

[dlunde]

Issue Summary

The test compiler/cha/TypeProfileFinalMethod.java exercises a specific compilation pattern and easily breaks by setting various VM flags (e.g., -Xcomp).

Changeset

• Make the test flagless.
• Ensure the test only compiles the intended methods.
• Fix problems with compiler directives used in the test (incorrect signatures and some directives getting unintentionally shadowed by other directives).
• Force C2 inlining of a method which the test author likely intended to always be inlined (based on source code comments in the test).
• Switch argument order in assertEquals to make error message correct.

Note for reviewers: A more fundamental rewrite of the test is beyond the scope of this changeset. The objective here is simply to ensure the test runs only in contexts intended by the test author.

Testing

• GitHub Actions
• tier1 and HotSpot parts of tier2 and tier3 (and additional Oracle-internal testing) on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.
• Stress testing of the specific test on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28200/head:pull/28200
$ git checkout pull/28200

Update a local copy of the PR:
$ git checkout pull/28200
$ git pull https://git.openjdk.org/jdk.git pull/28200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28200

View PR using the GUI difftool:
$ git pr show -t 28200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28200.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlunden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dlunde The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (da0d3140)